Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: media/base/decoder_buffer.h

Issue 17408005: Refactored DecoderBuffer to use unix_hacker_style naming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@localrefactor
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/decoder_buffer.h
diff --git a/media/base/decoder_buffer.h b/media/base/decoder_buffer.h
index d1c20ddda362673e2c5c191d0844c4714814cee7..fa332c8b4068d01700e79318c837063ae68955bb 100644
--- a/media/base/decoder_buffer.h
+++ b/media/base/decoder_buffer.h
@@ -26,7 +26,7 @@ class DecryptConfig;
//
// Also includes decoder specific functionality for decryption.
//
-// NOTE: It is illegal to call any method when IsEndOfStream() is true.
+// NOTE: It is illegal to call any method when end_of_stream() is true.
class MEDIA_EXPORT DecoderBuffer
: public base::RefCountedThreadSafe<DecoderBuffer> {
public:
@@ -56,29 +56,29 @@ class MEDIA_EXPORT DecoderBuffer
// Create a DecoderBuffer indicating we've reached end of stream.
//
- // Calling any method other than IsEndOfStream() on the resulting buffer
+ // Calling any method other than end_of_stream() on the resulting buffer
// is disallowed.
static scoped_refptr<DecoderBuffer> CreateEOSBuffer();
- base::TimeDelta GetTimestamp() const;
- void SetTimestamp(const base::TimeDelta& timestamp);
+ base::TimeDelta timestamp() const;
scherkus (not reviewing) 2013/07/08 23:30:35 these should all be inline as discussed in https:
Ty Overby 2013/07/09 00:50:30 Done.
+ void set_timestamp(const base::TimeDelta& timestamp);
- base::TimeDelta GetDuration() const;
- void SetDuration(const base::TimeDelta& duration);
+ base::TimeDelta duration() const;
+ void set_duration(const base::TimeDelta& duration);
- const uint8* GetData() const;
- uint8* GetWritableData() const;
+ const uint8* data() const;
+ uint8* writable_data() const;
- int GetDataSize() const;
+ int data_size() const;
- const uint8* GetSideData() const;
- int GetSideDataSize() const;
+ const uint8* side_data() const;
+ int side_data_size() const;
- const DecryptConfig* GetDecryptConfig() const;
- void SetDecryptConfig(scoped_ptr<DecryptConfig> decrypt_config);
+ const DecryptConfig* decrypt_config() const;
+ void set_decrypt_config(scoped_ptr<DecryptConfig> decrypt_config);
// If there's no data in this buffer, it represents end of stream.
- bool IsEndOfStream() const;
+ bool end_of_stream() const;
// Returns a human-readable string describing |*this|.
std::string AsHumanReadableString();

Powered by Google App Engine
This is Rietveld 408576698