Refactored DecoderBuffer to use unix_hacker_style naming.

media/base/decoder_buffer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_DECODER_BUFFER_H_
 #define MEDIA_BASE_DECODER_BUFFER_H_
 
 #include <string>
 
 #include "base/memory/aligned_memory.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/time.h"
 #include "build/build_config.h"
 #include "media/base/media_export.h"
 
 namespace media {
 
 class DecryptConfig;
 
 // A specialized buffer for interfacing with audio / video decoders.
 //
 // Specifically ensures that data is aligned and padded as necessary by the
 // underlying decoding framework.  On desktop platforms this means memory is
 // allocated using FFmpeg with particular alignment and padding requirements.
 //
 // Also includes decoder specific functionality for decryption.
 //
-// NOTE: It is illegal to call any method when IsEndOfStream() is true.
+// NOTE: It is illegal to call any method when is_end_of_stream() is true.
 class MEDIA_EXPORT DecoderBuffer
     : public base::RefCountedThreadSafe<DecoderBuffer> {
  public:
   enum {
     kPaddingSize = 16,
 #if defined(ARCH_CPU_ARM_FAMILY)
     kAlignmentSize = 16
 #else
     kAlignmentSize = 32
 #endif
   };
 
   // Allocates buffer with |size| >= 0.  Buffer will be padded and aligned
   // as necessary.
   explicit DecoderBuffer(int size);
 
   // Create a DecoderBuffer whose |data_| is copied from |data|.  Buffer will be
   // padded and aligned as necessary.  |data| must not be NULL and |size| >= 0.
-  static scoped_refptr<DecoderBuffer> CopyFrom(const uint8* data, int size);
+  static scoped_refptr<DecoderBuffer> copy_from(const uint8* data, int size);

[scherkus (not reviewing), 2013/06/20 21:26:59]

whoops! you changed too much :(

style guide states only simple getters/setters (like the ones below) get
unix_hacker style

complex methods are CamelCase (e.g., CopyFrom(), AsHumanReadableString())

 
   // Create a DecoderBuffer whose |data_| is copied from |data| and |side_data_|
   // is copied from |side_data|. Buffers will be padded and aligned as necessary
   // Data pointers must not be NULL and sizes must be >= 0.
-  static scoped_refptr<DecoderBuffer> CopyFrom(const uint8* data, int size,
+  static scoped_refptr<DecoderBuffer> copy_from(const uint8* data, int size,
                                                const uint8* side_data,
                                                int side_data_size);
 
   // Create a DecoderBuffer indicating we've reached end of stream.
   //
-  // Calling any method other than IsEndOfStream() on the resulting buffer
+  // Calling any method other than is_end_of_stream() on the resulting buffer
   // is disallowed.
-  static scoped_refptr<DecoderBuffer> CreateEOSBuffer();
+  static scoped_refptr<DecoderBuffer> create_eos_buffer();

[scherkus (not reviewing), 2013/06/20 21:26:59]

CreateEOSBuffer()

 
-  base::TimeDelta GetTimestamp() const;
-  void SetTimestamp(const base::TimeDelta& timestamp);
+  base::TimeDelta get_timestamp() const;

[scherkus (not reviewing), 2013/06/20 21:26:59]

with unix_hacker style getters don't feature the "get_" prefix

can you change this to:
timestamp()
set_timestamp(...)

as well as the rest below

+  void set_timestamp(const base::TimeDelta& timestamp);
 
-  base::TimeDelta GetDuration() const;
-  void SetDuration(const base::TimeDelta& duration);
+  base::TimeDelta get_duration() const;
+  void set_duration(const base::TimeDelta& duration);
 
-  const uint8* GetData() const;
-  uint8* GetWritableData() const;
+  const uint8* get_data() const;
+  uint8* get_writable_data() const;
 
-  int GetDataSize() const;
+  int get_data_size() const;
 
-  const uint8* GetSideData() const;
-  int GetSideDataSize() const;
+  const uint8* get_side_data() const;
+  int get_side_data_size() const;
 
-  const DecryptConfig* GetDecryptConfig() const;
+  const DecryptConfig* get_decrypt_config() const;
   void SetDecryptConfig(scoped_ptr<DecryptConfig> decrypt_config);
 
   // If there's no data in this buffer, it represents end of stream.
-  bool IsEndOfStream() const;
+  bool is_end_of_stream() const;

[scherkus (not reviewing), 2013/06/20 21:26:59]

similar story with bools getters where we don't feature an "is_" prefix:

bool end_of_stream() const;

 
   // Returns a human-readable string describing |*this|.
-  std::string AsHumanReadableString();
+  std::string as_human_readable_string();

[scherkus (not reviewing), 2013/06/20 21:26:59]

revert this change

 
  protected:
   friend class base::RefCountedThreadSafe<DecoderBuffer>;
 
   // Allocates a buffer of size |size| >= 0 and copies |data| into it.  Buffer
   // will be padded and aligned as necessary.  If |data| is NULL then |data_| is
   // set to NULL and |buffer_size_| to 0.
   DecoderBuffer(const uint8* data, int size,
                 const uint8* side_data, int side_data_size);
   virtual ~DecoderBuffer();
@@ skipping 10 matching lines @@
 
   // Constructor helper method for memory allocations.
   void Initialize();
 
   DISALLOW_COPY_AND_ASSIGN(DecoderBuffer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_DECODER_BUFFER_H_