[Mac][MC] Initial accessibility pass.

[Mac][MC] Initial accessibility pass.

This gives all the buttons appropriate roles, AXTitles, and makes accessible
more of the notification content.

BUG=238248
R=dewittj@chromium.org, dmazzoni@chromium.org, thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207994

[Nico, 2013-06-20 21:03:23]

lgtm, but I'm not super familiar with accessibility. (I'm somewhat familiar
though, and this looks right as far as I can tell.) +dmazzoni since he knows
this stuff, maybe he wants to take a look. (But you don't need to wait for him I
think.)

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/notif...
File ui/message_center/cocoa/notification_controller.mm (right):

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/notif...
ui/message_center/cocoa/notification_controller.mm:147: @end
Huh, this looks like something that should already exist somewhere.

[dmazzoni, 2013-06-20 23:05:10]

lgtm

Just a couple of things to check - but ultimately if it works with VoiceOver
that's excellent.

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/notif...
File ui/message_center/cocoa/notification_controller.mm (right):

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/notif...
ui/message_center/cocoa/notification_controller.mm:290: [listItemView_
accessibilitySetOverrideValue:NSAccessibilityListRole
This is a little confusing to me - is listItemView for a "list item", or is it
for a "list"?

I'd expect to see things with a role of NSAccessibilityListItemRole inside
something with a role of NSAccessibilityListRole.

I guess if it works with VoiceOver now, that's good. If it's working correctly,
then when you navigate to it you'd normally hear something like "list with 6
items".

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/tray_...
File ui/message_center/cocoa/tray_view_controller.mm (right):

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/tray_...
ui/message_center/cocoa/tray_view_controller.mm:465:
forAttribute:NSAccessibilityTitleAttribute];
Technically I think you're supposed to use NSAccessibilityDescriptionAttribute
for an accessible description that's not visible, and
NSAccessibilityTitleAttribute for text that's actually visible.

[dewittj, 2013-06-20 23:14:15]

lgtm

[Robert Sesek, 2013-06-22 01:56:00]

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/notif...
File ui/message_center/cocoa/notification_controller.mm (right):

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/notif...
ui/message_center/cocoa/notification_controller.mm:147: @end
On 2013/06/20 21:03:23, Nico wrote:
> Huh, this looks like something that should already exist somewhere.

I couldn't find it. There's some other AccessibilityIgnoredX things in chrome/,
so I think we can centralize them, though.

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/notif...
ui/message_center/cocoa/notification_controller.mm:290: [listItemView_
accessibilitySetOverrideValue:NSAccessibilityListRole
On 2013/06/20 23:05:10, Dominic Mazzoni wrote:
> This is a little confusing to me - is listItemView for a "list item", or is it
> for a "list"?

listItemView is a container for list items.

> I'd expect to see things with a role of NSAccessibilityListItemRole inside
> something with a role of NSAccessibilityListRole.

That was my expectation, too, but there is no ListItemRole. I think it goes by
AXChildren.

> I guess if it works with VoiceOver now, that's good. If it's working
correctly,
> then when you navigate to it you'd normally hear something like "list with 6
> items".

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/tray_...
File ui/message_center/cocoa/tray_view_controller.mm (right):

https://codereview.chromium.org/17408004/diff/1/ui/message_center/cocoa/tray_...
ui/message_center/cocoa/tray_view_controller.mm:465:
forAttribute:NSAccessibilityTitleAttribute];
On 2013/06/20 23:05:10, Dominic Mazzoni wrote:
> Technically I think you're supposed to use NSAccessibilityDescriptionAttribute
> for an accessible description that's not visible, and
> NSAccessibilityTitleAttribute for text that's actually visible.

You're right. Thanks for pointing that out. The documentation for
NSAccessibility is pretty sparse, and I didn't know the difference between it
and Help.

[Robert Sesek, 2013-06-22 02:29:21]

Committed patchset #2 manually as r207994 (presubmit successful).