Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1740753002:
[Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary (Closed)
Description[Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary
Adds the translation from optimized frame to bytecode offset
in FrameSummary. For interpreter, the bailout id represents the bytecode
array offset. So we can directly use the bailout id as the code offset
in the FrameSummary. Also updates mjsunit.status with more information
about failing tests.
BUG=v8:4280, v8:4689
LOG=N
Committed: https://crrev.com/844e410d5ce513beef2d2f635b63cc2f18d6df77
Cr-Commit-Position: refs/heads/master@{#34393}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Fixed comments #Patch Set 3 : rebased the patch #
Total comments: 3
Patch Set 4 : removed tests that are working from mjsunit.status #Patch Set 5 : Fix for a failing test on ia32. #Patch Set 6 : Reverts to pathcset 4 and skips a failing cctest. #
Messages
Total messages: 42 (21 generated)
Description was changed from ========== [Interpreter] Adds translation from optimized frame to bytecode offset in FrameSummary Adds the translation from the PC of optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 ========== to ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from the PC of optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 ==========
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740753002/1
Description was changed from ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from the PC of optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 ========== to ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from the ptimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11498)
Description was changed from ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from the ptimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 ========== to ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 ==========
Description was changed from ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 ========== to ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 LOG=N ==========
mythria@chromium.org changed reviewers: + rmcilroy@chromium.org
PTAL. Thanks, Mythri
https://codereview.chromium.org/1740753002/diff/1/src/frames.cc File src/frames.cc (right): https://codereview.chromium.org/1740753002/diff/1/src/frames.cc#newcode996 src/frames.cc:996: // based on the BytecodeArray and bytecode offset. Remove this TODO please https://codereview.chromium.org/1740753002/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1740753002/diff/1/test/mjsunit/mjsunit.status... test/mjsunit/mjsunit.status:863: # Related to lack of type feedback for calls in interpreter. Add a TODO(mythria,<bug_id>) with the id of the bug you just created. https://codereview.chromium.org/1740753002/diff/1/test/mjsunit/mjsunit.status... test/mjsunit/mjsunit.status:887: 'harmony/instanceof-es6': [SKIP], While you are here, could you change this SKIP to a FAIL please (looks like someone incorrectly added it as SKIP)
thanks, fixed comments. Thanks and Regards, Mythri https://codereview.chromium.org/1740753002/diff/1/src/frames.cc File src/frames.cc (right): https://codereview.chromium.org/1740753002/diff/1/src/frames.cc#newcode996 src/frames.cc:996: // based on the BytecodeArray and bytecode offset. On 2016/02/25 16:46:02, rmcilroy wrote: > Remove this TODO please Done. https://codereview.chromium.org/1740753002/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1740753002/diff/1/test/mjsunit/mjsunit.status... test/mjsunit/mjsunit.status:863: # Related to lack of type feedback for calls in interpreter. On 2016/02/25 16:46:02, rmcilroy wrote: > Add a TODO(mythria,<bug_id>) with the id of the bug you just created. Done. https://codereview.chromium.org/1740753002/diff/1/test/mjsunit/mjsunit.status... test/mjsunit/mjsunit.status:887: 'harmony/instanceof-es6': [SKIP], On 2016/02/25 16:46:02, rmcilroy wrote: > While you are here, could you change this SKIP to a FAIL please (looks like > someone incorrectly added it as SKIP) Done.
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740753002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/2006) v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/14405) v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/2005) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/2004) v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11571)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740753002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/2007) v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/2005) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740753002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740753002/60001
LGTM, but looks like you need to update the status file. https://codereview.chromium.org/1740753002/diff/40001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1740753002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:865: 'undetectable-compare': [FAIL], This has now been fixed https://codereview.chromium.org/1740753002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:870: 'regress/regress-4266': [FAIL], Looks like you've fixed this test now too (at least on some tests). https://codereview.chromium.org/1740753002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:877: 'harmony/instanceof-es6': [FAIL], Looks like this passes on some bots, just revert this change.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/14413)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740753002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740753002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Fixes a failing test on ia32. This is the same bug we found when during the callIC cl (https://codereview.chromium.org/1688283003/). We store a value above the esp and hence has problems with cpu-profiler. I pulled the same fix from that cl. Please take a look. Thanks, Mythri
Could you do the ia32 fix as a seperate CL please since it is unrelated to the other fix. You can TBR me on that fix and land both CLs tomorrow.
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740753002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740753002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mythria@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1740753002/#ps100001 (title: "Reverts to pathcset 4 and skips a failing cctest.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740753002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740753002/100001
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 LOG=N ========== to ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 LOG=N ========== to ========== [Interpreter] Adds translation of optimized frame to bytecode offset in FrameSummary Adds the translation from optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 LOG=N Committed: https://crrev.com/844e410d5ce513beef2d2f635b63cc2f18d6df77 Cr-Commit-Position: refs/heads/master@{#34393} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/844e410d5ce513beef2d2f635b63cc2f18d6df77 Cr-Commit-Position: refs/heads/master@{#34393} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
