Issue 174074: Check the favicon and loading state when a tab is created in case its TabCont...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174074: Check the favicon and loading state when a tab is created in case its TabCont... (Closed)

Created:
11 years, 4 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Check the favicon and loading state when a tab is created in case its TabContents is from an existing browser (such as torn off from a drag). BUG=18352 TEST=dragging a tab out with a favicon should keep the favicon. Creating new tabs should be unaffected. dragging a tab out with a throbber should show the throbber and change to the correct favicon. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23741

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -48 lines)			Patch
	M	chrome/browser/cocoa/tab_strip_controller.mm	View		4 chunks	+61 lines, -48 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 4 months ago (2009-08-19 20:43:28 UTC) #2

Looks good to me.

http://codereview.chromium.org/174074/diff/1/2
File chrome/browser/cocoa/tab_strip_controller.mm (right):

http://codereview.chromium.org/174074/diff/1/2#newcode623
Line 623: if (!contents) return;
I'd put the return on a line by itself.

I'd put it before the NSImages, too.

Expand Messages | Collapse Messages