LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html - Issue 174073007: Remove deprecated window.showModalDialog()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html

Issue 174073007: Remove deprecated window.showModalDialog() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Window/window-function-frame-getter-precedence.html ('k') | LayoutTests/fast/dom/Window/window-lookup-precedence.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html

diff --git a/LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html b/LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html

index 5f40c8649f03368cedfd33572da69553fafec2f7..7075254574b875f54a5aff883a57076efd758082 100644

--- a/LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html

+++ b/LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html

@@ -37,13 +37,7 @@

element.id = functionName;

document.body.appendChild(element);

- // showModalDialog only works on mac in the DRT. So run this test only if its defined and print output only on failure.

- // This'll keep the output consistent on all platforms.

- if (functionName == "showModalDialog") {

- if (window.showModalDialog != undefined)

- shouldBe("typeof window." + functionName, "function", true);

- } else

- shouldBe("typeof window." + functionName, "function");

+ shouldBe("typeof window." + functionName, "function");

document.body.removeChild(element);

}