Issue 174073006: Add a layout test for ImageDocument document.title

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174073006: Add a layout test for ImageDocument document.title (Closed)

Created:
6 years, 10 months ago by yi

Modified:
5 years, 9 months ago

Reviewers:
Noel Gordon

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

More Reviews

Description

Add a layout test for ImageDocument document.title According to comments inside ImageDocument, the document title should contain the natural image size. The test image has EXIF, which causes ImageDocument to draw the image rotated. The document.title should be the natural size: 1281 x 82. BUG=320244 R=noel@chromium.org TEST=fast/images/exif-orientation-height-image-document-title.html

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -3 lines)			Patch
	A	LayoutTests/fast/images/exif-orientation-height-image-document-title.html	View		1 chunk	+41 lines, -0 lines	1 comment	Download
	A +	LayoutTests/fast/images/exif-orientation-height-image-document-title-expected.txt	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Noel Gordon

6 years, 10 months ago (2014-02-21 05:26:45 UTC) #2

https://codereview.chromium.org/174073006/diff/1/LayoutTests/fast/images/exif...
File LayoutTests/fast/images/exif-orientation-height-image-document-title.html
(right):

https://codereview.chromium.org/174073006/diff/1/LayoutTests/fast/images/exif...
LayoutTests/fast/images/exif-orientation-height-image-document-title.html:31:
document.write(newwindow.document.title);
Can you think of a way to write this test that avoids using a setTimeout ?

Expand Messages | Collapse Messages