Overlay expected and actual repaint rects for LayoutTests.

LayoutTests/fast/harness/results.html

Index: LayoutTests/fast/harness/results.html
diff --git a/LayoutTests/fast/harness/results.html b/LayoutTests/fast/harness/results.html
index 1aeaae3a460c646cabc289560a74b8112e39f63b..57a821f5d98d230a7ad4d9fe1e83c339ebb276a4 100644
--- a/LayoutTests/fast/harness/results.html
+++ b/LayoutTests/fast/harness/results.html
@@ -424,7 +424,7 @@ function shouldUseTracLinks()
     return !globalState().results.layout_tests_dir || !location.toString().indexOf('file://') == 0;
 }
 
-function testLink(test)
+function testLinkTarget(test)
 {
     var target;
     if (shouldUseTracLinks()) {
@@ -435,6 +435,12 @@ function testLink(test)
         target += '#l1';
     } else
         target = globalState().results.layout_tests_dir + '/' + test;
+    return target;
+}
+
+function testLink(test)
+{
+    var target = testLinkTarget(test);
     return '<a class=test-link href="' + target + '">' + test + '</a><span class=flag onclick="unflag(this)"> \u2691</span>';
 }
 
@@ -516,7 +522,7 @@ function toggleImages()
     }
 }
 
-function textResultLinks(prefix)
+function textResultLinks(test, prefix)
 {
     var html = resultLink(prefix, '-expected.txt', 'expected') +
         resultLink(prefix, '-actual.txt', 'actual') +
@@ -528,6 +534,8 @@ function textResultLinks(prefix)
     if (globalState().results.has_wdiff)
         html += resultLink(prefix, '-wdiff.html', 'wdiff');
 
+    html += resultLink(prefix, '-overlay.html?' + encodeURIComponent(testLinkTarget(test)), 'overlay');

[ojan, 2014/02/25 00:43:42]

It's a bit of a bummer to have the (broken) overlay links even for non-repaint
tests. Can we add a bit to the json (e.g. like has_wdiff) for repaint tests?

[Dirk Pranke, 2014/02/27 20:57:44]

Agreed. I don't want to display a link that is irrelevant.

+
     return html;
 }
 
@@ -579,7 +587,7 @@ function tableRow(testObject)
         if (testObject.is_testharness_test) {
             row += resultLink(testPrefix, '-actual.txt', 'actual');
         } else {
-            row += textResultLinks(testPrefix);
+            row += textResultLinks(testObject.name, testPrefix);
         }
     }
     
@@ -683,7 +691,7 @@ function testList(tests, header, tableId)
             html += resultLink(stripExtension(test), '-sample.txt', 'sample');
         } else if (tableId == 'timeout-tests-table') {
             // FIXME: only include timeout actual/diff results here if we actually spit out results for timeout tests.
-            html += textResultLinks(stripExtension(test));
+            html += textResultLinks(test, stripExtension(test));
         }
         
         html += '</td></tr></tbody>';