Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 174063005: Win automatic toolchain: copy runtime dlls properly when not run from chrome/src. (Closed)

Created:
6 years, 10 months ago by mattm
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Win automatic toolchain: copy runtime dlls properly when not run from chrome/src. gclient runhooks runs gyp_chromium from the chrome/ dir, but the script was looking for out/ relative to that. BUG=323300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/gyp_chromium View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mattm
6 years, 10 months ago (2014-02-20 22:40:54 UTC) #1
scottmg
thanks, lgtm
6 years, 10 months ago (2014-02-20 22:42:55 UTC) #2
mattm
The CQ bit was checked by mattm@chromium.org
6 years, 10 months ago (2014-02-20 22:43:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/174063005/1
6 years, 10 months ago (2014-02-20 22:45:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 02:45:00 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=267484
6 years, 10 months ago (2014-02-21 02:45:00 UTC) #6
mattm
The CQ bit was checked by mattm@chromium.org
6 years, 10 months ago (2014-02-21 02:48:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/174063005/1
6 years, 10 months ago (2014-02-21 02:51:40 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 05:14:28 UTC) #9
Message was sent while issue was closed.
Change committed as 252500

Powered by Google App Engine
This is Rietveld 408576698