Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1740613002: Remove set but unsed variables. (Closed)

Created:
4 years, 9 months ago by Lei Zhang
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove set but unsed variables. And other nearby dead code. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6941d29a825a815bebf93e07c3f2e2274399c7a4

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -160 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M xfa.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_gridimp.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_C40Encoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_TextEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN13Writer.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN8Writer.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAWriter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
D xfa/src/fxfa/src/app/xfa_ffConfigAcc.h View 1 chunk +0 lines, -27 lines 0 comments Download
D xfa/src/fxfa/src/app/xfa_ffConfigAcc.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fontmgr.cpp View 3 chunks +7 lines, -10 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fm2jscontext.cpp View 1 4 chunks +4 lines, -10 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp View 1 4 chunks +5 lines, -12 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_object_imp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
4 years, 9 months ago (2016-02-25 05:31:10 UTC) #2
dsinclair
https://codereview.chromium.org/1740613002/diff/1/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp File xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp (left): https://codereview.chromium.org/1740613002/diff/1/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp#oldcode1718 xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp:1718: pMarginNode->GetMeasure(XFA_ATTRIBUTE_TopInset).ToUnit(XFA_UNIT_Pt); GetMeasure() has no side effects, yea?
4 years, 9 months ago (2016-02-25 14:14:59 UTC) #4
Lei Zhang
https://codereview.chromium.org/1740613002/diff/1/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp File xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp (left): https://codereview.chromium.org/1740613002/diff/1/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp#oldcode1718 xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp:1718: pMarginNode->GetMeasure(XFA_ATTRIBUTE_TopInset).ToUnit(XFA_UNIT_Pt); On 2016/02/25 14:14:59, dsinclair wrote: > GetMeasure() has ...
4 years, 9 months ago (2016-02-25 19:41:39 UTC) #5
dsinclair
lgtm
4 years, 9 months ago (2016-02-25 19:42:51 UTC) #6
Lei Zhang
4 years, 9 months ago (2016-02-25 20:08:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6941d29a825a815bebf93e07c3f2e2274399c7a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698