Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1726)

Unified Diff: runtime/bin/main.cc

Issue 17406010: Move getters from Options to Platform (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 9081f70cdd2aaf8810c4716633120ae2b51519da..3f13d964b7dcafcca96d13c1230b33c911d94701 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -402,15 +402,15 @@ static Dart_Handle SetupRuntimeOptions(CommandLineOptions* options,
if (Dart_IsError(io_lib)) {
return io_lib;
}
- Dart_Handle runtime_options_class_name =
- DartUtils::NewString("_OptionsImpl");
- if (Dart_IsError(runtime_options_class_name)) {
- return runtime_options_class_name;
+ Dart_Handle platform_class_name =
+ DartUtils::NewString("Platform");
+ if (Dart_IsError(platform_class_name)) {
+ return platform_class_name;
}
- Dart_Handle runtime_options_class = Dart_GetClass(
- io_lib, runtime_options_class_name);
- if (Dart_IsError(runtime_options_class)) {
- return runtime_options_class;
+ Dart_Handle platform_class = Dart_GetClass(
Ivan Posva 2013/06/24 21:16:46 It seems that this CL is out of sync. Dart_GetClas
+ io_lib, platform_class_name);
+ if (Dart_IsError(platform_class)) {
+ return platform_class;
}
Dart_Handle executable_name_name =
DartUtils::NewString("_nativeExecutable");
@@ -418,7 +418,7 @@ static Dart_Handle SetupRuntimeOptions(CommandLineOptions* options,
return executable_name_name;
}
Dart_Handle set_executable_name =
- Dart_SetField(runtime_options_class,
+ Dart_SetField(platform_class,
executable_name_name,
dart_executable);
if (Dart_IsError(set_executable_name)) {
@@ -429,10 +429,20 @@ static Dart_Handle SetupRuntimeOptions(CommandLineOptions* options,
return script_name_name;
}
Dart_Handle set_script_name =
- Dart_SetField(runtime_options_class, script_name_name, dart_script);
+ Dart_SetField(platform_class, script_name_name, dart_script);
if (Dart_IsError(set_script_name)) {
return set_script_name;
}
+ Dart_Handle runtime_options_class_name =
+ DartUtils::NewString("_OptionsImpl");
+ if (Dart_IsError(runtime_options_class_name)) {
+ return runtime_options_class_name;
+ }
+ Dart_Handle runtime_options_class = Dart_GetClass(
Ivan Posva 2013/06/24 21:16:46 Please use Dart_GetType instead of Dart_GetClass.
+ io_lib, runtime_options_class_name);
+ if (Dart_IsError(runtime_options_class)) {
+ return runtime_options_class;
+ }
Dart_Handle native_name = DartUtils::NewString("_nativeArguments");
if (Dart_IsError(native_name)) {
return native_name;
« no previous file with comments | « runtime/bin/io_natives.cc ('k') | runtime/bin/platform.cc » ('j') | utils/testrunner/utils.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698