Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 174058: Linux: Revert updating PRIMARY selection on Ctrl-C in omnibox. (Closed)

Created:
11 years, 4 months ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: Revert updating PRIMARY selection on Ctrl-C in omnibox. This backs out r23596. I'm pretty sure that it worked when I tested it right before submitting, but it's totally breaking stuff now -- it looks like when I update the PRIMARY selection, GTK notices that it's lost the selection and automatically unhighlights the text in the omnibox, making it impossible to use Ctrl-C to copy omnibox text to the clipboard. :-( BUG=19648 TESTED=Hit Ctrl-L, Ctrl-C and confirmed that text remains highlighted and becomes CLIPBOARD selection. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
11 years, 4 months ago (2009-08-19 15:54:28 UTC) #1
Evan Martin
11 years, 4 months ago (2009-08-19 15:57:05 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698