Build CodeSourceMap for each code object

Build CodeSourceMap for each code object

- Add helpers for building CodeSourceMap to FlowGraphCompiler. Ensure that no duplicate pc offsets are added to a CodeSourceMap.
- Add a CodeSourceMap debug printer which incorporates inlining information.
- Add some new classifying token positions.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/761e6a596319a24dc91f80b526f413b8b0f76584

[Cutch, 2016-02-24 23:52:53]

Description was changed from

==========
Build code -> source map for each code object

BUG=
==========

to

==========
Build CodeSourceMap for each code object

- Add helpers for building CodeSourceMap to FlowGraphCompiler. Ensure that no
duplicate pc offsets are added to a CodeSourceMap.
- Add a CodeSourceMap debug printer which incorporates inlining information.
- Add some new classifying token positions.
==========

[Cutch, 2016-02-24 23:52:53]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-02-24 23:53:13]

Patchset #1 (id:1) has been deleted

[Cutch, 2016-02-25 00:00:21]

Patchset #1 (id:20001) has been deleted

[rmacnak, 2016-02-25 23:04:40]

lgtm w/c

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/compi...
File runtime/vm/compiler.cc (right):

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/compi...
runtime/vm/compiler.cc:472: // Set the code source map after setting the inlined
information because
NOT_IN_PRODUCT

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/flow_...
File runtime/vm/flow_graph_compiler.cc (right):

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/flow_...
runtime/vm/flow_graph_compiler.cc:1798: // Remember how many bytes of code we
emitted. This function
emitted so far

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/flow_...
runtime/vm/flow_graph_compiler.cc:1798: // Remember how many bytes of code we
emitted. This function
NOT_IN_PRODUCT

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/flow_...
runtime/vm/flow_graph_compiler.cc:1805: // This function is called after each
instructions' EmitNativeCode.
NOT_IN_PRODUCT

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/flow_...
File runtime/vm/flow_graph_compiler.h (right):

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/flow_...
runtime/vm/flow_graph_compiler.h:598: void SaveCodeSize();
Consider BeginCodeSourceRange()/EndCodeSourceRange(token)

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/objec...
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/1740503002/diff/40001/runtime/vm/objec...
runtime/vm/object.cc:11087: pc_offset,
indent

[Cutch, 2016-02-26 15:59:22]

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:472: // Set the code source map after setting the inlined
information because
On 2016/02/25 23:04:40, rmacnak wrote:
> NOT_IN_PRODUCT

Done.

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:1798: // Remember how many bytes of code we
emitted. This function
On 2016/02/25 23:04:40, rmacnak wrote:
> emitted so far

Done.

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:1798: // Remember how many bytes of code we
emitted. This function
On 2016/02/25 23:04:40, rmacnak wrote:
> NOT_IN_PRODUCT

Done.

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:1805: // This function is called after each
instructions' EmitNativeCode.
On 2016/02/25 23:04:40, rmacnak wrote:
> NOT_IN_PRODUCT

Done.

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.h (right):

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.h:598: void SaveCodeSize();
On 2016/02/25 23:04:40, rmacnak wrote:
> Consider BeginCodeSourceRange()/EndCodeSourceRange(token)

Done.

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1740503002/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:11087: pc_offset,
On 2016/02/25 23:04:40, rmacnak wrote:
> indent

Done.

[Cutch, 2016-02-26 15:59:52]

Description was changed from

==========
Build CodeSourceMap for each code object

- Add helpers for building CodeSourceMap to FlowGraphCompiler. Ensure that no
duplicate pc offsets are added to a CodeSourceMap.
- Add a CodeSourceMap debug printer which incorporates inlining information.
- Add some new classifying token positions.
==========

to

==========
Build CodeSourceMap for each code object

- Add helpers for building CodeSourceMap to FlowGraphCompiler. Ensure that no
duplicate pc offsets are added to a CodeSourceMap.
- Add a CodeSourceMap debug printer which incorporates inlining information.
- Add some new classifying token positions.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/761e6a596319a24dc91f80b526f413b8b0f76584
==========

[Cutch, 2016-02-26 15:59:53]

Committed patchset #2 (id:60001) manually as
761e6a596319a24dc91f80b526f413b8b0f76584 (presubmit successful).