Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 1740443002: Fix WebrtcVideoCapturerAdapter to emit frames even when nothing is changing. (Closed)

Created:
4 years, 10 months ago by Sergey Ulanov
Modified:
4 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebrtcVideoCapturerAdapter to emit frames even when nothing is changing. Previously the adapter was signaling SignalVideoFrame only when the frame has changes. Video sender in Webrtc stack may drop some frames because VideoCapturer interface assumes that SignalVideoFrame is called regularly. As results the changes were sometimes delivered to the client too late. This change is a stopgap solution until we have proper frame capture scheduling that integrates with the video sender in webrtc. BUG=547158 Committed: https://crrev.com/9885938514890759da65019cbce59c1d637a2c6b Cr-Commit-Position: refs/heads/master@{#377459}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M remoting/protocol/webrtc_video_capturer_adapter.cc View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Ulanov
4 years, 10 months ago (2016-02-24 21:04:01 UTC) #2
Jamie
lgtm https://codereview.chromium.org/1740443002/diff/1/remoting/protocol/webrtc_video_capturer_adapter.cc File remoting/protocol/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/1740443002/diff/1/remoting/protocol/webrtc_video_capturer_adapter.cc#newcode164 remoting/protocol/webrtc_video_capturer_adapter.cc:164: if (!frame) If this is a stop-gap solution, ...
4 years, 10 months ago (2016-02-24 23:31:38 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1740443002/diff/1/remoting/protocol/webrtc_video_capturer_adapter.cc File remoting/protocol/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/1740443002/diff/1/remoting/protocol/webrtc_video_capturer_adapter.cc#newcode164 remoting/protocol/webrtc_video_capturer_adapter.cc:164: if (!frame) On 2016/02/24 23:31:38, Jamie wrote: > If ...
4 years, 10 months ago (2016-02-25 00:50:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740443002/20001
4 years, 10 months ago (2016-02-25 00:56:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-25 01:44:59 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 01:46:03 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9885938514890759da65019cbce59c1d637a2c6b
Cr-Commit-Position: refs/heads/master@{#377459}

Powered by Google App Engine
This is Rietveld 408576698