Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1740383002: remove unneeded view subclasses (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
scroggo, djsollen, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove unneeded view subclasses no doubt, more deletes will follow... goodbye old friends BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1740383002 TBR= Committed: https://skia.googlesource.com/skia/+/6b2af12a3954ef3dbbdbe927811eb0d9bca1c89a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1108 lines) Patch
M gyp/views.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
D include/views/SkWidget.h View 1 chunk +0 lines, -411 lines 0 comments Download
D src/views/SkProgressView.cpp View 1 chunk +0 lines, -132 lines 0 comments Download
D src/views/SkWidgets.cpp View 1 chunk +0 lines, -562 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740383002/1
4 years, 9 months ago (2016-02-27 19:37:30 UTC) #4
reed1
4 years, 9 months ago (2016-02-27 19:40:53 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-27 19:46:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740383002/1
4 years, 9 months ago (2016-02-27 20:50:35 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-02-27 20:51:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6b2af12a3954ef3dbbdbe927811eb0d9bca1c89a

Powered by Google App Engine
This is Rietveld 408576698