[wasm] Add a magic word and a version number to the binary.

[wasm] Add a magic word and a version number to the binary.

R=binji@chromium.org,jfb@chromium.org
BUG=

Committed: https://crrev.com/06241221a6cec82e8320b47c57ba23f18c3aabcc
Cr-Commit-Position: refs/heads/master@{#34346}

[binji, 2016-02-27 19:26:56]

lgtm

https://codereview.chromium.org/1740373002/diff/40001/test/mjsunit/wasm/wasm-...
File test/mjsunit/wasm/wasm-constants.js (right):

https://codereview.chromium.org/1740373002/diff/40001/test/mjsunit/wasm/wasm-...
test/mjsunit/wasm/wasm-constants.js:42: print(view[1]);
did you leave this in while testing?

https://codereview.chromium.org/1740373002/diff/40001/test/unittests/wasm/mod...
File test/unittests/wasm/module-decoder-unittest.cc (right):

https://codereview.chromium.org/1740373002/diff/40001/test/unittests/wasm/mod...
test/unittests/wasm/module-decoder-unittest.cc:57: byte* temp =
reinterpret_cast<byte*>(malloc(total));
pretty sure you can just static_cast from void* to byte*, but isn't

  new byte[total]

more natural for C++?

https://codereview.chromium.org/1740373002/diff/40001/test/unittests/wasm/mod...
test/unittests/wasm/module-decoder-unittest.cc:160: for (uint32_t i = 0; i <
1000000; i = i * 13 + 1) {
took me a sec to realize this value is basically arbitrary.

[JF, 2016-02-27 19:43:04]

lgtm with nits

sexpr-wasm will be rolled at the same time as this, to avoid waterfall breakage?

https://codereview.chromium.org/1740373002/diff/40001/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/1740373002/diff/40001/src/wasm/module-decoder...
src/wasm/module-decoder.cc:66: error(pos, pos, "expected magic bytes 0 a s m");
"0 a s m" will be incorrect if we change kWasmMagic. Can you %02x %02x %02x %02x
kWasmMagic in as below instead?

Also, can you print out magic_number?

https://codereview.chromium.org/1740373002/diff/40001/src/wasm/module-decoder...
src/wasm/module-decoder.cc:75: (kWasmVersion >> 16) & 0xff, (kWasmVersion >> 24)
& 0xff);
Same here, print magic_version.

https://codereview.chromium.org/1740373002/diff/40001/test/unittests/wasm/mod...
File test/unittests/wasm/module-decoder-unittest.cc (right):

https://codereview.chromium.org/1740373002/diff/40001/test/unittests/wasm/mod...
test/unittests/wasm/module-decoder-unittest.cc:57: byte* temp =
reinterpret_cast<byte*>(malloc(total));
On 2016/02/27 19:26:56, binji wrote:
> pretty sure you can just static_cast from void* to byte*, but isn't
> 
>   new byte[total]
> 
> more natural for C++?

Or use std::vector.

[titzer, 2016-02-27 23:05:10]

This is ready to land whenever sexpr-wasm is up to date.

https://codereview.chromium.org/1740373002/diff/40001/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/1740373002/diff/40001/src/wasm/module-decoder...
src/wasm/module-decoder.cc:66: error(pos, pos, "expected magic bytes 0 a s m");
On 2016/02/27 19:43:04, JF wrote:
> "0 a s m" will be incorrect if we change kWasmMagic. Can you %02x %02x %02x
%02x
> kWasmMagic in as below instead?
> 
> Also, can you print out magic_number?

Done.

https://codereview.chromium.org/1740373002/diff/40001/src/wasm/module-decoder...
src/wasm/module-decoder.cc:75: (kWasmVersion >> 16) & 0xff, (kWasmVersion >> 24)
& 0xff);
On 2016/02/27 19:43:04, JF wrote:
> Same here, print magic_version.

Done.

https://codereview.chromium.org/1740373002/diff/40001/test/mjsunit/wasm/wasm-...
File test/mjsunit/wasm/wasm-constants.js (right):

https://codereview.chromium.org/1740373002/diff/40001/test/mjsunit/wasm/wasm-...
test/mjsunit/wasm/wasm-constants.js:42: print(view[1]);
On 2016/02/27 19:26:56, binji wrote:
> did you leave this in while testing?

Good catch. Removed.

https://codereview.chromium.org/1740373002/diff/40001/test/unittests/wasm/mod...
File test/unittests/wasm/module-decoder-unittest.cc (right):

https://codereview.chromium.org/1740373002/diff/40001/test/unittests/wasm/mod...
test/unittests/wasm/module-decoder-unittest.cc:57: byte* temp =
reinterpret_cast<byte*>(malloc(total));
On 2016/02/27 19:26:56, binji wrote:
> pretty sure you can just static_cast from void* to byte*, but isn't
> 
>   new byte[total]
> 
> more natural for C++?

Done.

https://codereview.chromium.org/1740373002/diff/40001/test/unittests/wasm/mod...
test/unittests/wasm/module-decoder-unittest.cc:57: byte* temp =
reinterpret_cast<byte*>(malloc(total));
On 2016/02/27 19:43:04, JF wrote:
> On 2016/02/27 19:26:56, binji wrote:
> > pretty sure you can just static_cast from void* to byte*, but isn't
> > 
> >   new byte[total]
> > 
> > more natural for C++?
> 
> Or use std::vector.

Ewwww

[binji, 2016-02-27 23:25:06]

On 2016/02/27 23:05:10, titzer wrote:
> This is ready to land whenever sexpr-wasm is up to date.

Best to just land. I have a change, but since many of the sexpr-wasm tests rely
on d8, I'd have to break the tests and then fix them as soon as I roll v8 in
sexpr-wasm.

[binji, 2016-02-27 23:50:10]

On 2016/02/27 23:25:06, binji wrote:
> On 2016/02/27 23:05:10, titzer wrote:
> > This is ready to land whenever sexpr-wasm is up to date.
> 
> Best to just land. I have a change, but since many of the sexpr-wasm tests
rely
> on d8, I'd have to break the tests and then fix them as soon as I roll v8 in
> sexpr-wasm.

Actually, n/m. I'll just have sexpr-wasm fail, then fix when I roll v8 after
this patch.

Change here: https://github.com/WebAssembly/sexpr-wasm-prototype/pull/36
feel free to merge if you land this.

[titzer, 2016-02-28 00:35:01]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-02-28 00:35:02]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org,
jfb@chromium.org
Link to the patchset: https://codereview.chromium.org/1740373002/#ps90001
(title: " ")

[commit-bot: I haz the power, 2016-02-28 00:35:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1740373002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1740373002/90001

[commit-bot: I haz the power, 2016-02-28 00:37:18]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2016-02-28 00:37:40]

Description was changed from

==========
[wasm] Add a magic word and a version number to the binary.

R=binji@chromium.org,jfb@chromium.org
BUG=
==========

to

==========
[wasm] Add a magic word and a version number to the binary.

R=binji@chromium.org,jfb@chromium.org
BUG=

Committed: https://crrev.com/06241221a6cec82e8320b47c57ba23f18c3aabcc
Cr-Commit-Position: refs/heads/master@{#34346}
==========

[commit-bot: I haz the power, 2016-02-28 00:37:41]

Patchset 6 (id:??) landed as
https://crrev.com/06241221a6cec82e8320b47c57ba23f18c3aabcc
Cr-Commit-Position: refs/heads/master@{#34346}