Get rid of the extension's "Current Version" file.

chrome/browser/extensions/extensions_service_unittest.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 618 matching lines @@
       extension_manifest_errors::kMissingFile)) << GetErrors()[2];
 
   EXPECT_TRUE(MatchPattern(GetErrors()[3],
       std::string("Could not load extension from '*'. ") +
       extension_manifest_errors::kInvalidManifest)) << GetErrors()[3];
 };
 
 // Test that partially deleted extensions are cleaned up during startup
 // Test loading bad extensions from the profile directory.
 TEST_F(ExtensionsServiceTest, CleanupOnStartup) {
-  InitializeEmptyExtensionsService();
+  FilePath source_install_dir;
+  ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &source_install_dir));
+  source_install_dir = source_install_dir
+      .AppendASCII("extensions")
+      .AppendASCII("good")
+      .AppendASCII("Extensions");
+  FilePath pref_path = source_install_dir
+      .DirName()
+      .AppendASCII("Preferences");
 
-  FilePath source_path;
-  ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &source_path));
-  source_path = source_path.AppendASCII("extensions")
-                           .AppendASCII("good")
-                           .AppendASCII("Extensions");
+  InitializeInstalledExtensionsService(pref_path, source_install_dir);
 
-  file_util::Delete(extensions_install_dir_, true);
-
-  // Recursive.
-  file_util::CopyDirectory(source_path, extensions_install_dir_, true);
-
-  // Simulate that one of them got partially deleted by deling the
-  // Current Version file.
-  FilePath vers = extensions_install_dir_
-      .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
-      .AppendASCII(ExtensionsService::kCurrentVersionFileName);
-  ASSERT_TRUE(file_util::Delete(vers, false));  // not recursive
+  // Simulate that one of them got partially deleted by clearing its pref.
+  prefs_->GetMutableDictionary(L"extensions.settings")->
+      Remove(L"behllobkkfkfnphdnhnkndlbkcpglgmj", NULL);
 
   service_->Init();
   loop_.RunAllPending();
 
   file_util::FileEnumerator dirs(extensions_install_dir_, false,
                                  file_util::FileEnumerator::DIRECTORIES);
   size_t count = 0;
   while (!dirs.Next().empty())
     count++;
 
   // We should have only gotten two extensions now.
   EXPECT_EQ(2u, count);
 
   // And extension1 dir should now be toast.
-  vers = vers.DirName();
-  ASSERT_FALSE(file_util::PathExists(vers));
+  FilePath extension_dir = extensions_install_dir_
+      .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj");
+  ASSERT_FALSE(file_util::PathExists(extension_dir));
 }
 
 // Test installing extensions. This test tries to install few extensions using
 // crx files. If you need to change those crx files, feel free to repackage
 // them, throw away the key used and change the id's above.
 TEST_F(ExtensionsServiceTest, InstallExtension) {
   InitializeEmptyExtensionsService();
 
   FilePath extensions_path;
   ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &extensions_path));
@@ skipping 457 matching lines @@
   EXPECT_EQ(extension_id, unloaded_id_);
 
   ValidatePrefKeyCount(0);
 
   // The extension should not be in the service anymore.
   ASSERT_FALSE(service_->GetExtensionById(extension_id));
   loop_.RunAllPending();
 
   // The directory should be gone.
   EXPECT_FALSE(file_util::PathExists(extension_path));
-
-  // Try uinstalling one that doesn't have a Current Version file for some
-  // reason.
-  unloaded_id_.clear();
-  InstallExtension(path, true);
-  FilePath current_version_file =
-      extension_path.AppendASCII(ExtensionsService::kCurrentVersionFileName);
-  EXPECT_TRUE(file_util::Delete(current_version_file, true));
-  service_->UninstallExtension(extension_id, false);
-  loop_.RunAllPending();
-  EXPECT_FALSE(file_util::PathExists(extension_path));
-
-  ValidatePrefKeyCount(0);
 }
 
 // Tests loading single extensions (like --load-extension)
 TEST_F(ExtensionsServiceTest, LoadExtension) {
   InitializeEmptyExtensionsService();
   FilePath extensions_path;
   ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &extensions_path));
   extensions_path = extensions_path.AppendASCII("extensions");
 
   FilePath ext1 = extensions_path
@@ skipping 409 matching lines @@
 
   recorder.set_ready(false);
   command_line.reset(new CommandLine(L""));
   service = new ExtensionsService(&profile, command_line.get(),
       profile.GetPrefs(), install_dir, &loop, &loop, false);
   EXPECT_TRUE(service->extensions_enabled());
   service->Init();
   loop.RunAllPending();
   EXPECT_TRUE(recorder.ready());
 }