Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1740353002: Revert of Enable iPad Tab Switcher by default on iOS. (Closed)

Created:
4 years, 10 months ago by rohitrao (ping after 24h)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable iPad Tab Switcher by default on iOS. (patchset #3 id:200001 of https://codereview.chromium.org/1725533004/ ) Reason for revert: Broke iOS UI tests downstream. Original issue's description: > Enable iPad Tab Switcher by default on iOS. > > Enabling the Tab Switcher by default required fixing the > snapshot_cache unittests. > > In turn, this required fixing/cleaning the snapshot_cache: > -Always register/deregister for notifications. > -Centralize the logic to use a LRU cache. > -Centralize the logic to use an in-memory cache. > > Other changes: > -Replaced msarda with jif in OWNERS > -Trigger memory warning instead of calling |handleLowMemory| from tests. > > BUG=None > > Committed: https://crrev.com/7bc8524f4e0b9fa3a7758a81f195a0228196b8d4 > Cr-Commit-Position: refs/heads/master@{#377570} TBR=sdefresne@chromium.org,jbbegue@chromium.org,jif@google.com,jif@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Committed: https://crrev.com/01585070827f2015e350af60355eeb63b2281b35 Cr-Commit-Position: refs/heads/master@{#378098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -103 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/snapshots/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache.mm View 8 chunks +51 lines, -47 lines 0 comments Download
D ios/chrome/browser/snapshots/snapshot_cache_internal.h View 1 chunk +0 lines, -28 lines 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache_unittest.mm View 10 chunks +43 lines, -22 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
rohitrao (ping after 24h)
Created Revert of Enable iPad Tab Switcher by default on iOS.
4 years, 10 months ago (2016-02-27 02:09:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740353002/1
4 years, 10 months ago (2016-02-27 02:11:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740353002/1
4 years, 10 months ago (2016-02-27 02:32:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740353002/1
4 years, 10 months ago (2016-02-27 03:03:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-27 03:18:11 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/01585070827f2015e350af60355eeb63b2281b35 Cr-Commit-Position: refs/heads/master@{#378098}
4 years, 10 months ago (2016-02-27 03:19:16 UTC) #7
sdefresne
4 years, 9 months ago (2016-02-29 09:11:35 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698