components/update_client/ping_manager.cc - Issue 1740333002: Allow fallback from https to http for component update checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/ping_manager.cc

Issue 1740333002: Allow fallback from https to http for component update checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/updater/chrome_update_client_config.cc ('K') | « components/update_client/action_update_check.cc ('k') | components/update_client/request_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/update_client/ping_manager.cc

diff --git a/components/update_client/ping_manager.cc b/components/update_client/ping_manager.cc

index 191881457b5596271de9231e6449a8f37b3dd060..6c37aee5b503181e0e746fc80cf1157a0a6c57ec 100644

--- a/components/update_client/ping_manager.cc

+++ b/components/update_client/ping_manager.cc

@@ -179,7 +179,9 @@ class PingSender {

bool SendPing(const CrxUpdateItem* item);

private:

- void OnRequestSenderComplete(int error, const std::string& response);

+ void OnRequestSenderComplete(int error,

+ const std::string& response,

+ int retry_after_sec);

const scoped_refptr<Configurator> config_;

scoped_ptr<RequestSender> request_sender_;

@@ -196,7 +198,8 @@ PingSender::~PingSender() {

}

void PingSender::OnRequestSenderComplete(int error,

- const std::string& response) {

+ const std::string& response,

+ int retry_after_sec) {

DCHECK(thread_checker_.CalledOnValidThread());

delete this;

}