chrome/browser/component_updater/chrome_component_updater_configurator.cc - Issue 1740333002: Allow fallback from https to http for component update checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/chrome_component_updater_configurator.cc

Issue 1740333002: Allow fallback from https to http for component update checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc » ('j') | chrome/browser/extensions/updater/chrome_update_client_config.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/chrome_component_updater_configurator.cc

diff --git a/chrome/browser/component_updater/chrome_component_updater_configurator.cc b/chrome/browser/component_updater/chrome_component_updater_configurator.cc

index fcc40d52a96f1323ac8f6a5f75f763dc16480d8a..b4c487f61d459dc17216f2d6875a52df7d3126b0 100644

--- a/chrome/browser/component_updater/chrome_component_updater_configurator.cc

+++ b/chrome/browser/component_updater/chrome_component_updater_configurator.cc

@@ -62,10 +62,13 @@ class ChromeConfigurator : public update_client::Configurator {

~ChromeConfigurator() override {}

};

+// Allows the component updater to use non-encrypted communication with the

+// update backend. The security of the update checks is enforced using

+// a custom message signing protocol and it does not depend on using HTTPS.

ChromeConfigurator::ChromeConfigurator(

const base::CommandLine* cmdline,

net::URLRequestContextGetter* url_request_getter)

- : configurator_impl_(cmdline, url_request_getter) {}

+ : configurator_impl_(cmdline, url_request_getter, false) {}

int ChromeConfigurator::InitialDelay() const {

return configurator_impl_.InitialDelay();