chrome/browser/component_updater/widevine_cdm_component_installer.cc - Issue 1740333002: Allow fallback from https to http for component update checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/widevine_cdm_component_installer.cc

Issue 1740333002: Allow fallback from https to http for component update checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/sw_reporter_installer_win.cc ('k') | chrome/browser/extensions/updater/chrome_update_client_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/widevine_cdm_component_installer.cc

diff --git a/chrome/browser/component_updater/widevine_cdm_component_installer.cc b/chrome/browser/component_updater/widevine_cdm_component_installer.cc

index 8f74a949b0fdc85ceb9c1a9dd78864c9b2e2f250..f7b135e9a52636e29f07e98f423cf8b0bed6209c 100644

--- a/chrome/browser/component_updater/widevine_cdm_component_installer.cc

+++ b/chrome/browser/component_updater/widevine_cdm_component_installer.cc

@@ -236,6 +236,7 @@ class WidevineCdmComponentInstallerTraits : public ComponentInstallerTraits {

private:

// The following methods override ComponentInstallerTraits.

bool CanAutoUpdate() const override;

+ bool RequiresNetworkEncryption() const override;

bool OnCustomInstall(const base::DictionaryValue& manifest,

const base::FilePath& install_dir) override;

bool VerifyInstallation(

@@ -268,6 +269,10 @@ bool WidevineCdmComponentInstallerTraits::CanAutoUpdate() const {

return true;

}

+bool WidevineCdmComponentInstallerTraits::RequiresNetworkEncryption() const {

+ return false;

bool WidevineCdmComponentInstallerTraits::OnCustomInstall(

const base::DictionaryValue& manifest,

const base::FilePath& install_dir) {