Allow fallback from https to http for component update checks.

components/update_client/utils.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/update_client/utils.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 16 matching lines @@
 #include "components/update_client/configurator.h"
 #include "components/update_client/crx_update_item.h"
 #include "components/update_client/update_client.h"
 #include "components/update_client/update_query_params.h"
 #include "crypto/secure_hash.h"
 #include "crypto/sha2.h"
 #include "net/base/load_flags.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_status.h"
+#include "url/gurl.h"
 
 namespace update_client {
 
 namespace {
 
 // Returns the amount of physical memory in GB, rounded to the nearest GB.
 int GetPhysicalMemoryGB() {
   const double kOneGB = 1024 * 1024 * 1024;
   const int64_t phys_mem = base::SysInfo::AmountOfPhysicalMemory();
   return static_cast<int>(std::floor(0.5 + phys_mem / kOneGB));
@@ skipping 184 matching lines @@
 bool IsValidBrand(const std::string& brand) {
   const size_t kMaxBrandSize = 4;
   if (brand.size() > kMaxBrandSize)
     return false;
 
   return std::find_if_not(brand.begin(), brand.end(), [](char ch) {
            return base::IsAsciiAlpha(ch);
          }) == brand.end();
 }
 
+void RemoveUnsecureUrls(std::vector<GURL>* urls) {

[waffles, 2016/04/04 17:44:44]

It might be worth calling this "RemoveEncryptedUrls" or
"RemoveConfidentialUrls", since all our communications are "Secure" via CUP.

(If you do this, same idea elsewhere for local variable names, etc.)

[Sorin Jianu, 2016/04/04 18:01:40]

Acknowledged.

+  DCHECK(urls);
+  urls->erase(std::remove_if(
+                  urls->begin(), urls->end(),
+                  [](const GURL& url) { return !url.SchemeIsCryptographic(); }),
+              urls->end());
+}
+
 }  // namespace update_client