Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1740323002: Fix mojom_list_dart_outputs.py to not use the old Mojom parser. (Closed)

Created:
4 years, 9 months ago by rudominer
Modified:
4 years, 9 months ago
Reviewers:
Cutch, Ian McKellar, ianloic
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix mojom_list_dart_outputs.py to not use the old Mojom parser. Another occurrence of a use of the old Mojom parser that I missed. R=ianloic@google.com, johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/5a5c662446d9303412ad1400b0a7aab13a0ee0ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M mojo/public/tools/bindings/mojom_list_dart_outputs.py View 2 chunks +10 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rudominer
Ian discovered this. We think the reason that nobody else has complained must be that ...
4 years, 9 months ago (2016-02-27 00:01:33 UTC) #3
ianloic
On 2016/02/27 00:01:33, rudominer wrote: > Ian discovered this. We think the reason that nobody ...
4 years, 9 months ago (2016-02-27 00:15:41 UTC) #4
ianloic
lgtm
4 years, 9 months ago (2016-02-27 00:15:52 UTC) #6
Cutch
lgtm
4 years, 9 months ago (2016-02-29 20:24:46 UTC) #7
rudominer
4 years, 9 months ago (2016-02-29 20:26:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a5c662446d9303412ad1400b0a7aab13a0ee0ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698