Change default homepage experience.

Change default homepage experience.

We want to make google.com homepage by default and also show the home button (see the bug below).

BUG=http://crbug.com/19392
TEST=Delete user profile and launch Chrome - homepage should be set to google.com and should be enabled. also home button should show up.

[kuchhal, 2009-08-18 23:07:52]

Ben, can you OK this? Only couple of lines of code change but significant
functional change from our current behavior.

[Ben Goodger (Google), 2009-08-18 23:15:50]

On 2009/08/18 23:07:52, kuchhal wrote:
> Ben, can you OK this? Only couple of lines of code change but significant
> functional change from our current behavior.

I'm going to have to discuss the home button change with Glen.

[kuchhal, 2009-08-21 16:52:22]

Ben/Glen,

Any feedback yet?

[Peter Kasting, 2009-08-21 18:23:28]

I think we should not make these changes yet, and left comments on the bug
describing why.

[Ben Goodger (Google), 2009-08-22 07:06:36]

Glen and I need to discuss this with Brian/Linus next week.

We are not ready to accept this yet.

-Ben

On Fri, Aug 21, 2009 at 11:23 AM, <pkasting@chromium.org> wrote:
> I think we should not make these changes yet, and left comments on the
> bug describing why.
>
> http://codereview.chromium.org/174030
>

[Ben Goodger (Google), 2009-08-22 23:38:33]

From the looks of this change, it seems to me as if you're effectively
resetting the default behavior for all existing users as well. e.g. if
I've had Chrome installed and have been using the NTP but have never
changed my home page settings, this will effectively replace the NTP
with the Google home page for me. This is not an acceptable behavior.

-Ben

On Sat, Aug 22, 2009 at 12:06 AM, Ben Goodger (Google)<ben@chromium.org> wrote:
> Glen and I need to discuss this with Brian/Linus next week.
>
> We are not ready to accept this yet.
>
> -Ben
>
> On Fri, Aug 21, 2009 at 11:23 AM, <pkasting@chromium.org> wrote:
>> I think we should not make these changes yet, and left comments on the
>> bug describing why.
>>
>> http://codereview.chromium.org/174030
>>
>

[brakowski_google.com, 2009-08-24 03:22:01]

2009/8/22 Ben Goodger (Google) <ben@chromium.org>

>
> From the looks of this change, it seems to me as if you're effectively
> resetting the default behavior for all existing users as well. e.g. if
> I've had Chrome installed and have been using the NTP but have never
> changed my home page settings, this will effectively replace the NTP
> with the Google home page for me. This is not an acceptable behavior.
>

Agreed. This was not the intent.

>
> -Ben
>
> On Sat, Aug 22, 2009 at 12:06 AM, Ben Goodger (Google)<ben@chromium.org>
> wrote:
> > Glen and I need to discuss this with Brian/Linus next week.
> >
> > We are not ready to accept this yet.
> >
> > -Ben
> >
> > On Fri, Aug 21, 2009 at 11:23 AM, <pkasting@chromium.org> wrote:
> >> I think we should not make these changes yet, and left comments on the
> >> bug describing why.
> >>
> >> http://codereview.chromium.org/174030
> >>
> >
>

[kuchhal, 2009-08-24 16:40:20]

Ohh.. I was trying to change it only for new installs. Let me take a look.

On Sat, Aug 22, 2009 at 4:07 PM, Ben Goodger (Google) <ben@chromium.org>wrote:

> From the looks of this change, it seems to me as if you're effectively
> resetting the default behavior for all existing users as well. e.g. if
> I've had Chrome installed and have been using the NTP but have never
> changed my home page settings, this will effectively replace the NTP
> with the Google home page for me. This is not an acceptable behavior.
>
> -Ben
>
> On Sat, Aug 22, 2009 at 12:06 AM, Ben Goodger (Google)<ben@chromium.org>
> wrote:
> > Glen and I need to discuss this with Brian/Linus next week.
> >
> > We are not ready to accept this yet.
> >
> > -Ben
> >
> > On Fri, Aug 21, 2009 at 11:23 AM, <pkasting@chromium.org> wrote:
> >> I think we should not make these changes yet, and left comments on the
> >> bug describing why.
> >>
> >> http://codereview.chromium.org/174030
> >>
> >
>

[kuchhal, 2009-08-25 00:29:28]

Changed to set new values only during First Run as that seems to be a way to
tell if an install is new (other than some kind of master preference from
installer which we are trying to avoid).

[kuchhal, 2009-08-27 22:25:36]

Ben can you take a look at the new changes?

On Mon, Aug 24, 2009 at 5:29 PM, <kuchhal@chromium.org> wrote:

> Changed to set new values only during First Run as that seems to be a
> way to tell if an install is new (other than some kind of master
> preference from installer which we are trying to avoid).
>
>
>
> http://codereview.chromium.org/174030
>

[Ben Goodger (Google), 2009-08-27 22:29:17]

OK.