Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1740243003:
Remove Now v1 component cleanup. (Closed)
|
Created:
4 years, 10 months ago by skare_ Modified:
4 years, 5 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove Now v1 component cleanup.
BUG=539674
Committed: https://crrev.com/8070db4925bfd7cd86f27349abcade02ac8d8767
Cr-Commit-Position: refs/heads/master@{#403260}
Patch Set 1 #
Total comments: 2
Patch Set 2 : more dead code removal #
Messages
Total messages: 20 (8 generated)
Description was changed from ========== Remove Now cleanup. BUG= ========== to ========== Remove Now v1 component cleanup. BUG=539674 ==========
skare@chromium.org changed reviewers: + robliao@chromium.org
https://codereview.chromium.org/1740243003/diff/1/chrome/browser/extensions/c... File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/1740243003/diff/1/chrome/browser/extensions/c... chrome/browser/extensions/component_loader.cc:12: #include "base/metrics/field_trial.h" Haven't tried it, but a few of these includes may no longer be necessary. base/metrics/field_trial.h chrome/common/channel_info.h chrome/browser/signin/signin_manager_factory.h components/signin/core/browser/signin_manager.h components/signin/core/browser/signin_manager_base.h App List Include chrome/browser/ui/app_list/google_now_extension.h https://codereview.chromium.org/1740243003/diff/1/chrome/browser/extensions/c... chrome/browser/extensions/component_loader.cc:677: const base::FilePath& root_directory) { Might as well remove this as well.
On 2016/03/02 22:00:52, robliao wrote: > https://codereview.chromium.org/1740243003/diff/1/chrome/browser/extensions/c... > File chrome/browser/extensions/component_loader.cc (right): > > https://codereview.chromium.org/1740243003/diff/1/chrome/browser/extensions/c... > chrome/browser/extensions/component_loader.cc:12: #include > "base/metrics/field_trial.h" > Haven't tried it, but a few of these includes may no longer be necessary. > > base/metrics/field_trial.h > chrome/common/channel_info.h > chrome/browser/signin/signin_manager_factory.h > components/signin/core/browser/signin_manager.h > components/signin/core/browser/signin_manager_base.h > > App List Include > chrome/browser/ui/app_list/google_now_extension.h > > https://codereview.chromium.org/1740243003/diff/1/chrome/browser/extensions/c... > chrome/browser/extensions/component_loader.cc:677: const base::FilePath& > root_directory) { > Might as well remove this as well. cleaned up those references. thought this was covered by another CL but, nope, sorry for the delay :/
lgtm
skare@chromium.org changed reviewers: + rdevlin.cronin@chromium.org
rdevlin.cronin@chromium.org: Please review for component_loader OWNERS
lgtm
The CQ bit was checked by skare@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by skare@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove Now v1 component cleanup. BUG=539674 ========== to ========== Remove Now v1 component cleanup. BUG=539674 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Remove Now v1 component cleanup. BUG=539674 ========== to ========== Remove Now v1 component cleanup. BUG=539674 Committed: https://crrev.com/8070db4925bfd7cd86f27349abcade02ac8d8767 Cr-Commit-Position: refs/heads/master@{#403260} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8070db4925bfd7cd86f27349abcade02ac8d8767 Cr-Commit-Position: refs/heads/master@{#403260} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
