Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1740213003: New GM that exercises gamma-correctness in various parts of the pipeline. (Closed)

Created:
4 years, 10 months ago by Brian Osman
Modified:
4 years, 10 months ago
Reviewers:
mtklein, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

New GM that exercises gamma-correctness in various parts of the pipeline. Attempts to render 50% grey through many different techniques. Only the first one (black/white dither) is guaranteed to be correct. This serves as ground-truth for all the others (independent of whatever your display may or may not be doing when viewing the output of the GM). Current tests: - Texture bilerp - Texture scale (ie mipmaps) - Simple paint color - Gradient - A handful of Xfer modes - 50% grey bitmaps, both linear and sRGB - Bitmaps wrapped in shaders, which hits a different raster code path TODO: - Test coverage (rather than alpha)? - Text, Blur, etc...? Re-landing this without the blitter selection change, which may have caused a regression. Also updated the text color so it's legible against both black (SampleApp) and white (gold). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1740213003 Committed: https://skia.googlesource.com/skia/+/e5824b90da4568544ecbf71ba5d690095b31307e

Patch Set 1 #

Patch Set 2 : Fixed to use saveLayer so that the output images are opaque. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -0 lines) Patch
A gm/gamma.cpp View 1 1 chunk +171 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Brian Osman
Omitting the blitter fix, so I can land the GM without breaking the MacMini bot.
4 years, 10 months ago (2016-02-26 18:53:19 UTC) #3
Brian Osman
4 years, 10 months ago (2016-02-26 19:40:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740213003/20001
4 years, 10 months ago (2016-02-26 19:40:33 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-26 19:40:34 UTC) #7
bsalomon
On 2016/02/26 19:40:34, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
4 years, 10 months ago (2016-02-26 19:42:05 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 19:57:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e5824b90da4568544ecbf71ba5d690095b31307e

Powered by Google App Engine
This is Rietveld 408576698