Fix the coordinates for touch selection.

Fix the coordinates for touch selection.

* The selection bounds attached to CompositorFrameMetaData is in viewport coordinates.  This needs to be converted to DIP for browser somewhere. For now, this CL convert it in browser  side rather than renderer side because the code that computes the selection bounds is in cc/  rather than content/renderer. Consider move that part ot content/renderer and move this to there instead.

BUG=585043
TEST=TouchSelectionControllerClientAuraScaleFactorTest*. manual.

Committed: https://crrev.com/93b827d99389ad0ce61362695ad641b14ca33180
Cr-Commit-Position: refs/heads/master@{#378500}

[oshima, 2016-02-26 17:43:57]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 17:45:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1740193002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1740193002/1

[oshima, 2016-02-26 18:29:01]

Description was changed from

==========
Fix the coordinates for touch selection. * The selection bounds attached to
CompositorFrameMetaData is in viewport coordinates.  This needs to be converted
to DIP for browser somewhere. For now, this CL convert it in browser  side
rather than renderer side because the code that computes the selection bounds is
in cc/  rather than content/renderer. Consider move that part ot
content/renderer and move this to there instead.

BUG=585043
TEST=manual.
==========

to

==========
Fix the coordinates for touch selection.

* The selection bounds attached to CompositorFrameMetaData is in viewport
coordinates.  This needs to be converted to DIP for browser somewhere. For now,
this CL convert it in browser  side rather than renderer side because the code
that computes the selection bounds is in cc/  rather than content/renderer.
Consider move that part ot content/renderer and move this to there instead.

BUG=585043
TEST=manual.
==========

[oshima, 2016-02-26 18:29:01]

oshima@chromium.org changed reviewers:
+ mohsen@chromium.org, tdresser@chromium.org

[oshima, 2016-02-26 18:59:11]

This is alternative approach to https://codereview.chromium.org/1697483003/.

[commit-bot: I haz the power, 2016-02-26 20:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 20:56:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[oshima, 2016-02-26 23:08:43]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 23:09:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1740193002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1740193002/1

[commit-bot: I haz the power, 2016-02-27 01:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-27 01:21:06]

Dry run: This issue passed the CQ dry run.

[tdresser, 2016-02-29 15:38:03]

mohsen@, is there a reasonable place for an automated test for this change?

[mohsen, 2016-02-29 17:08:17]

On 2016/02/29 at 15:38:03, tdresser wrote:
> mohsen@, is there a reasonable place for an automated test for this change?

I'd say a browser test in
content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc.

[oshima, 2016-03-01 04:02:12]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 04:02:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1740193002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1740193002/30001

[commit-bot: I haz the power, 2016-03-01 04:33:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 04:33:52]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[oshima, 2016-03-01 15:25:02]

Patchset #3 (id:30001) has been deleted

[oshima, 2016-03-01 15:26:06]

Patchset #2 (id:20001) has been deleted

[oshima, 2016-03-01 15:26:11]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 15:26:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1740193002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1740193002/50001

[oshima, 2016-03-01 15:26:54]

PTAL. I made a few refactoring in the test file.

[oshima, 2016-03-01 15:27:21]

Description was changed from

==========
Fix the coordinates for touch selection.

* The selection bounds attached to CompositorFrameMetaData is in viewport
coordinates.  This needs to be converted to DIP for browser somewhere. For now,
this CL convert it in browser  side rather than renderer side because the code
that computes the selection bounds is in cc/  rather than content/renderer.
Consider move that part ot content/renderer and move this to there instead.

BUG=585043
TEST=manual.
==========

to

==========
Fix the coordinates for touch selection.

* The selection bounds attached to CompositorFrameMetaData is in viewport
coordinates.  This needs to be converted to DIP for browser somewhere. For now,
this CL convert it in browser  side rather than renderer side because the code
that computes the selection bounds is in cc/  rather than content/renderer.
Consider move that part ot content/renderer and move this to there instead.

BUG=585043
TEST=TouchSelectionControllerClientAuraScaleFactorTest*. manual.
==========

[tdresser, 2016-03-01 15:31:29]

lgtm

[mohsen, 2016-03-01 16:47:49]

lgtm

[oshima, 2016-03-01 16:51:21]

oshima@chromium.org changed reviewers:
+ pfeldman@chromium.org

[oshima, 2016-03-01 16:51:22]

+pfeldman@ requesting owners approval for content/renderer

[commit-bot: I haz the power, 2016-03-01 16:53:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 16:53:23]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-03-01 18:24:56]

lgtm

[oshima, 2016-03-01 18:50:22]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-03-01 18:51:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1740193002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1740193002/50001

[commit-bot: I haz the power, 2016-03-01 18:58:53]

Description was changed from

==========
Fix the coordinates for touch selection.

* The selection bounds attached to CompositorFrameMetaData is in viewport
coordinates.  This needs to be converted to DIP for browser somewhere. For now,
this CL convert it in browser  side rather than renderer side because the code
that computes the selection bounds is in cc/  rather than content/renderer.
Consider move that part ot content/renderer and move this to there instead.

BUG=585043
TEST=TouchSelectionControllerClientAuraScaleFactorTest*. manual.
==========

to

==========
Fix the coordinates for touch selection.

* The selection bounds attached to CompositorFrameMetaData is in viewport
coordinates.  This needs to be converted to DIP for browser somewhere. For now,
this CL convert it in browser  side rather than renderer side because the code
that computes the selection bounds is in cc/  rather than content/renderer.
Consider move that part ot content/renderer and move this to there instead.

BUG=585043
TEST=TouchSelectionControllerClientAuraScaleFactorTest*. manual.
==========

[commit-bot: I haz the power, 2016-03-01 18:58:55]

Committed patchset #2 (id:50001)

[commit-bot: I haz the power, 2016-03-01 19:00:01]

Description was changed from

==========
Fix the coordinates for touch selection.

* The selection bounds attached to CompositorFrameMetaData is in viewport
coordinates.  This needs to be converted to DIP for browser somewhere. For now,
this CL convert it in browser  side rather than renderer side because the code
that computes the selection bounds is in cc/  rather than content/renderer.
Consider move that part ot content/renderer and move this to there instead.

BUG=585043
TEST=TouchSelectionControllerClientAuraScaleFactorTest*. manual.
==========

to

==========
Fix the coordinates for touch selection.

* The selection bounds attached to CompositorFrameMetaData is in viewport
coordinates.  This needs to be converted to DIP for browser somewhere. For now,
this CL convert it in browser  side rather than renderer side because the code
that computes the selection bounds is in cc/  rather than content/renderer.
Consider move that part ot content/renderer and move this to there instead.

BUG=585043
TEST=TouchSelectionControllerClientAuraScaleFactorTest*. manual.

Committed: https://crrev.com/93b827d99389ad0ce61362695ad641b14ca33180
Cr-Commit-Position: refs/heads/master@{#378500}
==========

[commit-bot: I haz the power, 2016-03-01 19:00:03]

Patchset 2 (id:??) landed as
https://crrev.com/93b827d99389ad0ce61362695ad641b14ca33180
Cr-Commit-Position: refs/heads/master@{#378500}