Issue 174018: Disable mute/unmute when media does not have an audio track.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174018: Disable mute/unmute when media does not have an audio track. (Closed)

Created:
11 years, 4 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Disable mute/unmute when media does not have an audio track. BUG=18970 TEST=test matrix videos ending in 0 should have mute context menu disabled

Patch Set 2 : uploaded too much #

Patch Set 3 : app engine 500 :( #

Patch Set 4 : Removed blank line #

Patch Set 5 : uploaded too much (again) #

Total comments: 2

Patch Set 8 : Merged #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1 2 3 4 5 6 7	1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 2 3 4 5 6 7	1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/glue/context_menu.h	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -1 line	0 comments	Download
M	webkit/glue/context_menu_client_impl.cc	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

awong

one small question. http://codereview.chromium.org/174018/diff/31/32 File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/174018/diff/31/32#newcode319 Line 319: case IDS_CONTENT_CONTEXT_LOOP: To confirm, we're ...

11 years, 4 months ago (2009-08-18 20:34:50 UTC) #2

scherkus (not reviewing)

http://codereview.chromium.org/174018/diff/31/32 File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/174018/diff/31/32#newcode319 Line 319: case IDS_CONTENT_CONTEXT_LOOP: On 2009/08/18 20:34:50, awong wrote: > ...

11 years, 4 months ago (2009-08-18 21:51:08 UTC) #3

LGTM