third_party/WebKit/Source/core/editing/PlainTextRange.cpp - Issue 1740173003: TextIteratorAlgorithm should not force layout update in constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/PlainTextRange.cpp

Issue 1740173003: TextIteratorAlgorithm should not force layout update in constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed my WIP comment. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingTestBase.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/PlainTextRange.cpp

diff --git a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp

index 7cfb84d3ba034f28437dd9c0c45e3f34382c3cb6..3fb2866a20f4847f050d6c595e447317f23a3ab8 100644

--- a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp

+++ b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp

@@ -82,6 +82,11 @@ EphemeralRange PlainTextRange::createRangeFor(const ContainerNode& scope, GetRan

if (getRangeFor == ForSelection)

behaviorFlags |= TextIteratorEmitsCharactersBetweenAllVisiblePositions;

auto range = EphemeralRange::rangeOfContents(scope);

+ // TODO(dglazkov): The use of updateLayoutIgnorePendingStylesheets needs to be audited.

+ // see http://crbug.com/590369 for more details.

+ scope.document().updateLayoutIgnorePendingStylesheets();

TextIterator it(range.startPosition(), range.endPosition(), behaviorFlags);

// FIXME: the atEnd() check shouldn't be necessary, workaround for