content/renderer/render_view_impl.cc - Issue 1740173003: TextIteratorAlgorithm should not force layout update in constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 1740173003: TextIteratorAlgorithm should not force layout update in constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed my WIP comment. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 4278f55ebd838195a20558483194a50a5d5d1e5f..8c520bd03f348f14391a36830f8178e231faabd0 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1258,6 +1258,7 @@ void RenderViewImpl::OnGetRenderedText() {

// sends text in the wrong order. See http://crbug.com/584798.

// TODO(dglazkov): WebFrameContentDumper should only be used for

// testing purposes. See http://crbug.com/585164.

+ webview()->updateAllLifecyclePhases();

std::string text =

WebFrameContentDumper::dumpFrameTreeAsText(

webview()->mainFrame()->toWebLocalFrame(), kMaximumMessageSize)

« no previous file with comments | « content/renderer/render_view_browsertest_mac.mm ('k') | third_party/WebKit/Source/core/editing/EditingTestBase.cpp » ('j') | no next file with comments »