src/core/SkPaint.cpp - Issue 1740163002: Improve horizontal baseline detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPaint.cpp

Issue 1740163002: Improve horizontal baseline detection. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Just the bug fixes first. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPaint.cpp

diff --git a/src/core/SkPaint.cpp b/src/core/SkPaint.cpp

index 060e905ec79c578cf8f871cdfc6b176642c7a27f..017662ff48bead0a00263c42336719f544d2475f 100644

--- a/src/core/SkPaint.cpp

+++ b/src/core/SkPaint.cpp

@@ -1318,7 +1318,7 @@ static bool too_big_for_lcd(const SkScalerContext::Rec& rec, bool checkPost2x2)

* typically returns the same looking resuts for tiny changes in the matrix.

static SkScalar sk_relax(SkScalar x) {

- int n = sk_float_round2int(x * 1024);

+ SkScalar n = SkScalarRoundToScalar(x * 1024);

return n / 1024.0f;

}