Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 174015: Add automation call to wait for multiple navigations. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
huanr, tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add automation call to wait for multiple navigations. Convert one ErrorPage UI test to use it. The rest of the tests will require more work. TEST=Covered by ui_tests. http://crbug.com/19361, http://crbug.com/19395

Patch Set 1 #

Total comments: 1

Patch Set 2 : backwards compatibility #

Total comments: 2

Patch Set 3 : backwards compatibility, properly done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -52 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 19 chunks +32 lines, -17 lines 0 comments Download
M chrome/browser/errorpage_uitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_test_base.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/automation/tab_proxy.h View 1 chunk +14 lines, -4 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 2 1 chunk +23 lines, -4 lines 0 comments Download
M chrome/test/memory_test/memory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Paweł Hajdan Jr.
11 years, 4 months ago (2009-08-18 19:44:50 UTC) #1
tony
http://codereview.chromium.org/174015/diff/1/7 File chrome/test/automation/automation_messages_internal.h (right): http://codereview.chromium.org/174015/diff/1/7#newcode86 Line 86: IPC_SYNC_MESSAGE_ROUTED3_1(AutomationMsg_NavigateToURL, int, GURL, int, I think this is ...
11 years, 4 months ago (2009-08-18 20:04:22 UTC) #2
Paweł Hajdan Jr.
Fixed.
11 years, 4 months ago (2009-08-18 20:58:25 UTC) #3
tony
LGTM http://codereview.chromium.org/174015/diff/1003/1009 File chrome/test/automation/automation_messages_internal.h (right): http://codereview.chromium.org/174015/diff/1003/1009#newcode85 Line 85: // TODO(phajdan.jr): Remove when the reference build ...
11 years, 4 months ago (2009-08-18 21:15:17 UTC) #4
huanr
LGTM http://codereview.chromium.org/174015/diff/1003/1007 File chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc (right): http://codereview.chromium.org/174015/diff/1003/1007#newcode151 Line 151: tab->NavigateToURL(server->TestServerPageW(L"files/title2.html")); Is it safe to switch to ...
11 years, 4 months ago (2009-08-19 04:05:25 UTC) #5
Paweł Hajdan Jr.
I had to revert because it broke reference page cycler tests. After this fix they ...
11 years, 4 months ago (2009-08-19 19:43:38 UTC) #6
tony
I see, you had to still send the old IPC. Yes, LGTM.
11 years, 4 months ago (2009-08-19 19:48:11 UTC) #7
huanr
11 years, 4 months ago (2009-08-19 20:03:33 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698