Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174013010: Make selector list pseudos work with class invalidation sets. (Closed)

Created:
6 years, 10 months ago by rune
Modified:
6 years, 10 months ago
Reviewers:
chrishtr, esprehn
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Make selector list pseudos work with class invalidation sets. Selectors like :not and :-webkit-any have selector lists. Classes, ids and tag names in those lists were not taken into account when building class invalidation sets. Re-introduce a white-list for supported pseudos and disallow :not and :-webkit-any for now. R=esprehn@chromium.org,chrishtr@chromium.org BUG=344893 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167560

Patch Set 1 #

Total comments: 4

Patch Set 2 : Check colors before class change. #

Patch Set 3 : Moved tests to invalidation directory. #

Total comments: 2

Patch Set 4 : More readable colors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -3 lines) Patch
A LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo.html View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo-expected.txt View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +49 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
rune
6 years, 10 months ago (2014-02-20 22:28:36 UTC) #1
chrishtr
https://codereview.chromium.org/174013010/diff/1/LayoutTests/fast/css/dynamic-selector-list-pseudo.html File LayoutTests/fast/css/dynamic-selector-list-pseudo.html (right): https://codereview.chromium.org/174013010/diff/1/LayoutTests/fast/css/dynamic-selector-list-pseudo.html#newcode1 LayoutTests/fast/css/dynamic-selector-list-pseudo.html:1: <!DOCTYPE html> Add to the targetedstylerecalc virtual test suite ...
6 years, 10 months ago (2014-02-20 22:34:49 UTC) #2
esprehn
lgtm for the whitelist, please fix the tests per chrishtr's comments.
6 years, 10 months ago (2014-02-20 22:53:17 UTC) #3
rune
https://codereview.chromium.org/174013010/diff/1/LayoutTests/fast/css/dynamic-selector-list-pseudo.html File LayoutTests/fast/css/dynamic-selector-list-pseudo.html (right): https://codereview.chromium.org/174013010/diff/1/LayoutTests/fast/css/dynamic-selector-list-pseudo.html#newcode1 LayoutTests/fast/css/dynamic-selector-list-pseudo.html:1: <!DOCTYPE html> On 2014/02/20 22:34:49, Chris Harrelson wrote: > ...
6 years, 10 months ago (2014-02-20 22:59:33 UTC) #4
rune
The CQ bit was checked by rune@opera.com
6 years, 10 months ago (2014-02-20 23:00:58 UTC) #5
chrishtr
I don't see the virtual part? https://codereview.chromium.org/174013010/diff/90001/LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo.html File LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo.html (right): https://codereview.chromium.org/174013010/diff/90001/LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo.html#newcode31 LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo.html:31: shouldBe("getComputedStyle(t1, null).backgroundColor", "'rgba(0, ...
6 years, 10 months ago (2014-02-20 23:03:18 UTC) #6
rune
The CQ bit was unchecked by rune@opera.com
6 years, 10 months ago (2014-02-20 23:04:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/174013010/90001
6 years, 10 months ago (2014-02-20 23:07:09 UTC) #8
rune
On 2014/02/20 23:03:18, Chris Harrelson wrote: > I don't see the virtual part? It's moved ...
6 years, 10 months ago (2014-02-20 23:18:55 UTC) #9
rune
https://codereview.chromium.org/174013010/diff/90001/LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo.html File LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo.html (right): https://codereview.chromium.org/174013010/diff/90001/LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo.html#newcode31 LayoutTests/fast/css/invalidation/dynamic-selector-list-pseudo.html:31: shouldBe("getComputedStyle(t1, null).backgroundColor", "'rgba(0, 0, 0, 0)'"); On 2014/02/20 23:03:19, ...
6 years, 10 months ago (2014-02-20 23:19:13 UTC) #10
chrishtr
lgtm Right, my bad about the virtual test.
6 years, 10 months ago (2014-02-20 23:22:16 UTC) #11
rune
The CQ bit was checked by rune@opera.com
6 years, 10 months ago (2014-02-20 23:24:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/174013010/200001
6 years, 10 months ago (2014-02-20 23:24:40 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 02:12:12 UTC) #14
Message was sent while issue was closed. 
Change committed as 167560

Powered by Google App Engine
This is Rietveld 408576698