Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: PRESUBMIT.py

Issue 174013007: Add UMA stats to record when DLLs are successfully blocked in the Browser. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Alignment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
887 887
888 888
889 def _CheckSpamLogging(input_api, output_api): 889 def _CheckSpamLogging(input_api, output_api):
890 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS 890 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS
891 black_list = (_EXCLUDED_PATHS + 891 black_list = (_EXCLUDED_PATHS +
892 _TEST_CODE_EXCLUDED_PATHS + 892 _TEST_CODE_EXCLUDED_PATHS +
893 input_api.DEFAULT_BLACK_LIST + 893 input_api.DEFAULT_BLACK_LIST +
894 (r"^base[\\\/]logging\.h$", 894 (r"^base[\\\/]logging\.h$",
895 r"^base[\\\/]logging\.cc$", 895 r"^base[\\\/]logging\.cc$",
896 r"^cloud_print[\\\/]", 896 r"^cloud_print[\\\/]",
897 r"^chrome_elf[\\\/]dll_hash[\\\/]dll_hash_main\.cc$",
897 r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$", 898 r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$",
898 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", 899 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$",
899 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]" 900 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]"
900 r"startup_browser_creator\.cc$", 901 r"startup_browser_creator\.cc$",
901 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", 902 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*",
902 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]" 903 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]"
903 r"logging_native_handler\.cc$", 904 r"logging_native_handler\.cc$",
904 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]" 905 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]"
905 r"gl_helper_benchmark\.cc$", 906 r"gl_helper_benchmark\.cc$",
906 r"^remoting[\\\/]base[\\\/]logging\.h$", 907 r"^remoting[\\\/]base[\\\/]logging\.h$",
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
1421 trybots.extend(GetDefaultTryConfigs(['cros_x86'])) 1422 trybots.extend(GetDefaultTryConfigs(['cros_x86']))
1422 1423
1423 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1424 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1424 # unless they're .gyp(i) files as changes to those files can break the gyp 1425 # unless they're .gyp(i) files as changes to those files can break the gyp
1425 # step on that bot. 1426 # step on that bot.
1426 if (not all(re.search('^chrome', f) for f in files) or 1427 if (not all(re.search('^chrome', f) for f in files) or
1427 any(re.search('\.gypi?$', f) for f in files)): 1428 any(re.search('\.gypi?$', f) for f in files)):
1428 trybots.extend(GetDefaultTryConfigs(['android_aosp'])) 1429 trybots.extend(GetDefaultTryConfigs(['android_aosp']))
1429 1430
1430 return trybots 1431 return trybots
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698