Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: src/compiler/simplified-lowering.h

Issue 1740123002: [turbofan] Bailout if LoadBuffer typing assumption doesn't hold. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_SIMPLIFIED_LOWERING_H_ 5 #ifndef V8_COMPILER_SIMPLIFIED_LOWERING_H_
6 #define V8_COMPILER_SIMPLIFIED_LOWERING_H_ 6 #define V8_COMPILER_SIMPLIFIED_LOWERING_H_
7 7
8 #include "src/compiler/js-graph.h" 8 #include "src/compiler/js-graph.h"
9 #include "src/compiler/machine-operator.h" 9 #include "src/compiler/machine-operator.h"
10 #include "src/compiler/node.h" 10 #include "src/compiler/node.h"
(...skipping 23 matching lines...) Expand all
34 // TODO(turbofan): The representation can be removed once the result of the 34 // TODO(turbofan): The representation can be removed once the result of the
35 // representation analysis is stored in the node bounds. 35 // representation analysis is stored in the node bounds.
36 void DoLoadBuffer(Node* node, MachineRepresentation rep, 36 void DoLoadBuffer(Node* node, MachineRepresentation rep,
37 RepresentationChanger* changer); 37 RepresentationChanger* changer);
38 void DoStoreBuffer(Node* node); 38 void DoStoreBuffer(Node* node);
39 void DoShift(Node* node, Operator const* op, Type* rhs_type); 39 void DoShift(Node* node, Operator const* op, Type* rhs_type);
40 void DoStringEqual(Node* node); 40 void DoStringEqual(Node* node);
41 void DoStringLessThan(Node* node); 41 void DoStringLessThan(Node* node);
42 void DoStringLessThanOrEqual(Node* node); 42 void DoStringLessThanOrEqual(Node* node);
43 43
44 // TODO(bmeurer): This is a gigantic hack to support the gigantic LoadBuffer
45 // typing hack to support the gigantic "asm.js should be fast without proper
46 // verifier"-hack, ... Kill this! Soon! Really soon! I'm serious!
47 bool abort_compilation_ = false;
48
44 private: 49 private:
45 JSGraph* const jsgraph_; 50 JSGraph* const jsgraph_;
46 Zone* const zone_; 51 Zone* const zone_;
47 TypeCache const& type_cache_; 52 TypeCache const& type_cache_;
48 53
49 // TODO(danno): SimplifiedLowering shouldn't know anything about the source 54 // TODO(danno): SimplifiedLowering shouldn't know anything about the source
50 // positions table, but must for now since there currently is no other way to 55 // positions table, but must for now since there currently is no other way to
51 // pass down source position information to nodes created during 56 // pass down source position information to nodes created during
52 // lowering. Once this phase becomes a vanilla reducer, it should get source 57 // lowering. Once this phase becomes a vanilla reducer, it should get source
53 // position information via the SourcePositionWrapper like all other reducers. 58 // position information via the SourcePositionWrapper like all other reducers.
(...skipping 13 matching lines...) Expand all
67 Graph* graph() { return jsgraph()->graph(); } 72 Graph* graph() { return jsgraph()->graph(); }
68 CommonOperatorBuilder* common() { return jsgraph()->common(); } 73 CommonOperatorBuilder* common() { return jsgraph()->common(); }
69 MachineOperatorBuilder* machine() { return jsgraph()->machine(); } 74 MachineOperatorBuilder* machine() { return jsgraph()->machine(); }
70 }; 75 };
71 76
72 } // namespace compiler 77 } // namespace compiler
73 } // namespace internal 78 } // namespace internal
74 } // namespace v8 79 } // namespace v8
75 80
76 #endif // V8_COMPILER_SIMPLIFIED_LOWERING_H_ 81 #endif // V8_COMPILER_SIMPLIFIED_LOWERING_H_
OLDNEW
« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698