Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1740093002: [mojo-edk] Pass process handle through the broker on all platforms. (Closed)

Created:
4 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Pass process handle through the broker on all platforms. This is necessary on OSX for mach ports. On Linux, this is unnecessary, but it's cleaner to just support it. BUG=582468 Committed: https://crrev.com/e1fcd6a47ba14a0fbfc7b0f8b4ccad6e16437a49 Cr-Commit-Position: refs/heads/master@{#378068}

Patch Set 1 #

Patch Set 2 : Windows #

Patch Set 3 : Maybe fix build? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -23 lines) Patch
M mojo/edk/system/node_channel.h View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/node_channel.cc View 5 chunks +26 lines, -14 lines 0 comments Download
M mojo/edk/system/node_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/node_controller.cc View 1 2 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Anand Mistry (off Chromium)
4 years, 10 months ago (2016-02-26 08:43:25 UTC) #2
Ken Rockot(use gerrit already)
LGTM - I kinda wanted to do this anyway, since the cost is marginal and ...
4 years, 10 months ago (2016-02-26 17:50:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740093002/40001
4 years, 10 months ago (2016-02-26 23:09:56 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-02-27 01:49:48 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-27 01:51:07 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e1fcd6a47ba14a0fbfc7b0f8b4ccad6e16437a49
Cr-Commit-Position: refs/heads/master@{#378068}

Powered by Google App Engine
This is Rietveld 408576698