Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2832)

Unified Diff: chrome/android/java/res/layout/website_settings.xml

Issue 1740063002: [Offline pages] Adding the status icon to the OIB (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@omnibox-patch-2
Patch Set: Updating content description for the icon Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/website_settings.xml
diff --git a/chrome/android/java/res/layout/website_settings.xml b/chrome/android/java/res/layout/website_settings.xml
index 9cc5ee33953a023664cfbc8e8e92d02fe8e895a6..a8d3cc1ab6582b554b20915d113c2371166265db 100644
--- a/chrome/android/java/res/layout/website_settings.xml
+++ b/chrome/android/java/res/layout/website_settings.xml
@@ -20,16 +20,33 @@
android:paddingEnd="@dimen/website_settings_popup_padding_sides"
android:paddingStart="@dimen/website_settings_popup_padding_sides" >
- <view class="org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup$ElidedUrlTextView"
- android:id="@+id/website_settings_url"
+ <LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:ellipsize="end"
- android:lineSpacingExtra="6dp"
- android:paddingTop="16dp"
- android:textAlignment="viewStart"
- android:textColor="@color/url_emphasis_default_text"
- android:textSize="16sp"/>
+ android:orientation="horizontal"
+ android:paddingTop="16dp" >
+
+ <ImageView android:id="@+id/offline_icon"
+ style="@style/LocationBarButton"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_gravity="start|top"
+ android:paddingEnd="12dp"
+ android:src="@drawable/offline_bolt"
+ android:visibility="gone"
+ android:contentDescription="@string/page_info_offline_icon" />
+
+ <view class="org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup$ElidedUrlTextView"
+ android:id="@+id/website_settings_url"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:ellipsize="end"
+ android:lineSpacingExtra="6dp"
+ android:textAlignment="viewStart"
+ android:textColor="@color/url_emphasis_default_text"
+ android:textSize="16sp"/>
+
+ </LinearLayout>
<TextView
android:id="@+id/website_settings_connection_message"
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698