Force __pnacl_pso_root to be an external declaration.

src/PNaClTranslator.cpp

Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index 1fb84c16b76e32f44592ed8670210b7e12031439..edee9e5241c54975623de047a83335a47746d06d 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -476,6 +476,12 @@ private:
                               const char *DeclType,
                               NaClBcIndexSize_t &NameIndex) {
     if (Decl->hasName()) {
+      if (Decl->isPNaClABIExternalName()) {
+        // Force linkage to be external for the PNaCl ABI. PNaCl bitcode has a
+        // linkage field for Functions, but not for GlobalVariables (because the
+        // latter is not needed for pexes, so it has been removed).
+        Decl->setLinkage(llvm::GlobalValue::ExternalLinkage);

[Mark Seaborn, 2016/02/26 23:18:58]

It looks like you're doing this for functions, but that's not ideal -- you
should only do this for GlobalVariables.

+      }
       Translator.checkIfUnnamedNameSafe(Decl->getName(), DeclType, Prefix);
     } else {
       Decl->setName(Translator.createUnnamedName(Prefix, NameIndex));