Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/PNaClTranslator.cpp

Issue 1740033002: Force __pnacl_pso_root to be an external declaration. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Removing unused argument Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/IceGlobalInits.h ('K') | « src/IceGlobalInits.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index 1fb84c16b76e32f44592ed8670210b7e12031439..2c9e98f1bfd5e458ee5b988eaeae655e72b33688 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -547,8 +547,8 @@ private:
// Converts global variable declarations into constant value IDs.
void createValueIDsForGlobalVars() {
Ice::GlobalContext *Ctx = getTranslator().getContext();
- for (const Ice::VariableDeclaration *Decl : *VariableDeclarations) {
- if (!Decl->verifyLinkageCorrect(Ctx))
+ for (Ice::VariableDeclaration *Decl : *VariableDeclarations) {
+ if (!Decl->verifyLinkageCorrect(Ctx) && !Decl->forcePNaClABILinkage())
reportLinkageError("Global", *Decl);
Ice::Constant *C =
getConstantSym(Decl->getName(), Decl->getSuppressMangling(),
« src/IceGlobalInits.h ('K') | « src/IceGlobalInits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698