Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: runtime/vm/object.cc

Issue 1739963002: Remember token position where a function was inlined (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index a4aeb27dd1848520371ed11a001b550aff95bfc1..49a9d01b033d9885078ff393c4c3b5c73c4c7dd8 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -12740,6 +12740,29 @@ void Code::SetInlinedIdToFunction(const Array& value) const {
}
+RawArray* Code::GetInlinedIdToTokenPos() const {
+ const Array& metadata = Array::Handle(raw_ptr()->inlined_metadata_);
+ if (metadata.IsNull()) {
+ return metadata.raw();
+ }
+ return reinterpret_cast<RawArray*>(
+ metadata.At(RawCode::kInlinedIdToTokenPosIndex));
+}
+
+
+void Code::SetInlinedIdToTokenPos(const Array& value) const {
+ if (raw_ptr()->inlined_metadata_ == Array::null()) {
+ StorePointer(&raw_ptr()->inlined_metadata_,
+ Array::New(RawCode::kInlinedMetadataSize, Heap::kOld));
+ }
+ const Array& metadata = Array::Handle(raw_ptr()->inlined_metadata_);
+ ASSERT(!metadata.IsNull());
+ ASSERT(metadata.IsOld());
+ ASSERT(value.IsOld());
+ metadata.SetAt(RawCode::kInlinedIdToTokenPosIndex, value);
+}
+
+
RawArray* Code::GetInlinedCallerIdMap() const {
const Array& metadata = Array::Handle(raw_ptr()->inlined_metadata_);
if (metadata.IsNull()) {
@@ -13205,9 +13228,16 @@ void Code::DumpInlinedIntervals() const {
THR_Print(" %" Pd ": %s\n", i, function.ToQualifiedCString());
}
}
+ THR_Print("Inlined token pos:\n");
+ const Array& token_pos_map = Array::Handle(GetInlinedIdToTokenPos());
+ Smi& smi = Smi::Handle();
+ for (intptr_t i = 0; i < token_pos_map.Length(); i++) {
+ smi ^= token_pos_map.At(i);
+ TokenPosition tp = TokenPosition(smi.Value());
+ THR_Print(" %" Pd ": %s\n", i, tp.ToCString());
+ }
THR_Print("Caller Inlining Ids:\n");
const Array& caller_map = Array::Handle(GetInlinedCallerIdMap());
- Smi& smi = Smi::Handle();
for (intptr_t i = 0; i < caller_map.Length(); i++) {
smi ^= caller_map.At(i);
THR_Print(" iid: %" Pd " caller iid: %" Pd "\n", i, smi.Value());

Powered by Google App Engine
This is Rietveld 408576698