Remember token position where a function was inlined

Remember token position where a function was inlined

When inlining a function, remember the token position of the call. I need this information for source level profiling.

R=srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/3b0104732b308a6464060ee8acbb9c7b22f9b8ce

[Cutch, 2016-02-25 21:41:43]

Description was changed from

==========
Remember token position where a function was inlined
==========

to

==========
Remember token position where a function was inlined

When inlining a function, remember the token position of the call. I need this
information for source level profiling.
==========

[Cutch, 2016-02-25 21:41:44]

johnmccutchan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2016-02-25 22:05:32]

lgtm

https://codereview.chromium.org/1739963002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1739963002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:482: // 'start' and 'end' are pc-offsets.
Adjust comment, there is no 'end; field any longer. Maybe add comment that
token_pos is inlined function's token_pos.

https://codereview.chromium.org/1739963002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:1768: const Array& res = Array::Handle(
zone()

https://codereview.chromium.org/1739963002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:1770: Smi& smi = Smi::Handle();
zone()

[Cutch, 2016-02-25 22:36:40]

Thanks!

https://codereview.chromium.org/1739963002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1739963002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:482: // 'start' and 'end' are pc-offsets.
On 2016/02/25 22:05:32, srdjan wrote:
> Adjust comment, there is no 'end; field any longer. Maybe add comment that
> token_pos is inlined function's token_pos.

Done.

https://codereview.chromium.org/1739963002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:1768: const Array& res = Array::Handle(
On 2016/02/25 22:05:32, srdjan wrote:
> zone()

Done.

https://codereview.chromium.org/1739963002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:1770: Smi& smi = Smi::Handle();
On 2016/02/25 22:05:32, srdjan wrote:
> zone()

Done.

[Cutch, 2016-02-25 22:47:15]

Description was changed from

==========
Remember token position where a function was inlined

When inlining a function, remember the token position of the call. I need this
information for source level profiling.
==========

to

==========
Remember token position where a function was inlined

When inlining a function, remember the token position of the call. I need this
information for source level profiling.

R=srdjan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3b0104732b308a6464060ee8acbb9c7b22f9b8ce
==========

[Cutch, 2016-02-25 22:47:17]

Committed patchset #2 (id:20001) manually as
3b0104732b308a6464060ee8acbb9c7b22f9b8ce (presubmit successful).