Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1739923002: Move package summary reading code into analyzer. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move package summary reading code into analyzer. This will allow it to be re-used by DDC. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c6314577ff5743345086285bda6e017ccde55c73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -217 lines) Patch
A pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 1 chunk +224 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/package_analyzer.dart View 2 chunks +1 line, -217 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-25 20:11:02 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-25 20:12:00 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-25 21:13:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c6314577ff5743345086285bda6e017ccde55c73 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698