Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1739903002: Revert of md5check'ify lint.py (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of md5check'ify lint.py (patchset #2 id:20001 of https://codereview.chromium.org/1730143003/ ) Reason for revert: Breaking bots. Original issue's description: > md5check'ify lint.py > > When locally building chrome_public_apk_incremental and making a > non-public change to a content_java file, this brings ninja time: > > 24s -> 7s > > BUG=None > > Committed: https://crrev.com/b84f70aeb94075c8f6ec85a8211b231a9125ba41 > Cr-Commit-Position: refs/heads/master@{#377614} TBR=jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/c9332a02c50696fd24323176099aae2a69162d02 Cr-Commit-Position: refs/heads/master@{#377650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -39 lines) Patch
M build/android/gyp/lint.py View 7 chunks +24 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
agrieve
Created Revert of md5check'ify lint.py
4 years, 9 months ago (2016-02-25 19:48:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739903002/1
4 years, 9 months ago (2016-02-25 19:51:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-25 19:55:47 UTC) #3
agrieve
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1733893003/ by agrieve@chromium.org. ...
4 years, 9 months ago (2016-02-25 19:57:20 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-02-25 19:58:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9332a02c50696fd24323176099aae2a69162d02
Cr-Commit-Position: refs/heads/master@{#377650}

Powered by Google App Engine
This is Rietveld 408576698