Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2076)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1739893006: Skip PaintLayer empty paint phases if it previously painted nothing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 71fc4248e32f484e2cc9f956f8fa2c97926aa084..c78b58c3c353149ffd873d2f4e39fc31ceca2619 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -1482,15 +1482,15 @@ bool LayoutBox::intersectsVisibleViewport()
PaintInvalidationReason LayoutBox::invalidatePaintIfNeeded(PaintInvalidationState& paintInvalidationState, const LayoutBoxModelObject& paintInvalidationContainer)
{
- if (isFloating())
- paintInvalidationState.enclosingSelfPaintingLayer(*this).setNeedsPaintPhaseFloat();
-
- if (hasBoxDecorationBackground()
- // We also paint overflow controls in background phase.
- || (hasOverflowClip() && getScrollableArea()->hasOverflowControls())) {
- PaintLayer& layer = paintInvalidationState.enclosingSelfPaintingLayer(*this);
- if (layer.layoutObject() != this)
- layer.setNeedsPaintPhaseDescendantBlockBackgrounds();
+ PaintLayer& enclosingSelfPaintingLayer = paintInvalidationState.enclosingSelfPaintingLayer(*this);
+ if (enclosingSelfPaintingLayer.layoutObject() != this) {
+ if (isFloating())
+ enclosingSelfPaintingLayer.setNeedsPaintPhaseFloat();
+
+ if (hasBoxDecorationBackground()
+ // We also paint overflow controls in background phase.
+ || (hasOverflowClip() && getScrollableArea()->hasOverflowControls()))
+ enclosingSelfPaintingLayer.setNeedsPaintPhaseDescendantBlockBackgrounds();
}
PaintInvalidationReason fullInvalidationReason = fullPaintInvalidationReason();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698