Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 173983002: Refactoring: Redesign option parsing in push and merge scripts. (Closed)

Created:
6 years, 10 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev, tfarina
Visibility:
Public.

Description

Refactoring: Redesign option parsing in push and merge scripts. - Deprecate optparse with argparse - Connect the top-level scripts via inheritance and remove top-level functions - Options and option processing can be extended from base to subclass script - All options have now long names - The tests include now options parsing by default: each test specifies the command-line args to parse rather than the options directly

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -358 lines) Patch
M tools/push-to-trunk/auto_roll.py View 5 chunks +36 lines, -63 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 4 chunks +76 lines, -28 lines 0 comments Download
M tools/push-to-trunk/merge_to_branch.py View 4 chunks +60 lines, -91 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 6 chunks +69 lines, -123 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 13 chunks +39 lines, -53 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
PTAL
6 years, 10 months ago (2014-02-21 13:57:11 UTC) #1
tfarina
are these scripts used by buildbot? Do they have python 2.7? argparse may not be ...
6 years, 10 months ago (2014-02-21 17:03:18 UTC) #2
Michael Achenbach
No - these are all scripts use by developers locally only. Should be no problem.
6 years, 10 months ago (2014-02-21 20:43:00 UTC) #3
tfarina
Moving myself to CC list as I'm not reviewing this. Removed Ravi as well.
6 years, 10 months ago (2014-02-24 01:20:18 UTC) #4
ulan
On 2014/02/24 01:20:18, tfarina wrote: > Moving myself to CC list as I'm not reviewing ...
6 years, 10 months ago (2014-02-24 07:36:30 UTC) #5
Michael Achenbach
6 years, 10 months ago (2014-02-24 15:47:36 UTC) #6
On 2014/02/24 07:36:30, ulan wrote:
> On 2014/02/24 01:20:18, tfarina wrote:
> > Moving myself to CC list as I'm not reviewing this. Removed Ravi as well.
> 
> > - Deprecate optparse with argparse 
> > - Connect the top-level scripts via inheritance and remove top-level
functions
> 
> > - Options and option processing can be extended from base to subclass script

> > - All options have now long names 
> > - The tests include now options parsing by default: each test specifies the
> command-line args to parse rather than the options directly
> Any reason why this is one big CL instead of five small CLs?

I'll try to split in in smaller chunks...

Powered by Google App Engine
This is Rietveld 408576698