Add tests and settings plumbing for accelerated fixed root background

Add tests and settings plumbing for accelerated fixed root background. The implementation is coming in this patch https://codereview.chromium.org/13462003/.

This patch also adds tests from this WebKit patch by Simon Fraser:
https://bugs.webkit.org/show_bug.cgi?id=115951
LayoutTests/platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html.html
LayoutTests/platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed.html


BUG=180885
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153639

[Ian Vollick, 2013-06-21 14:38:56]

Hey James. I've broken the tests and settings stuff into a separate patch. When
you have a moment, PTAL.

[Ian Vollick, 2013-06-21 14:42:08]

+jamesr for real.

Addressing comments from the old, aggregate patch
https://codereview.chromium.org/13462003/.
>
https://codereview.chromium.org/13462003/diff/57001/LayoutTests/compositing/f...
> File LayoutTests/compositing/fixed-background-composited-html.html (right):
> 
>
https://codereview.chromium.org/13462003/diff/57001/LayoutTests/compositing/f...
> LayoutTests/compositing/fixed-background-composited-html.html:27:
> window.setTimeout(function() {
> what's the setTimeout for?
> 
>
https://codereview.chromium.org/13462003/diff/57001/LayoutTests/compositing/f...
> File LayoutTests/compositing/fixed-background-negative-z-index-fixed.html
> (right):
> 
>
https://codereview.chromium.org/13462003/diff/57001/LayoutTests/compositing/f...
> LayoutTests/compositing/fixed-background-negative-z-index-fixed.html:32:
> window.setTimeout(function() {
> what's the setTimeout for?

AFAICT, the setTimeouts serve no purpose, so I've removed them.

[Ian Vollick, 2013-06-25 20:16:45]

On 2013/06/21 14:42:08, vollick wrote:
> +jamesr for real.
> 
> Addressing comments from the old, aggregate patch
> https://codereview.chromium.org/13462003/.
> >
>
https://codereview.chromium.org/13462003/diff/57001/LayoutTests/compositing/f...
> > File LayoutTests/compositing/fixed-background-composited-html.html (right):
> > 
> >
>
https://codereview.chromium.org/13462003/diff/57001/LayoutTests/compositing/f...
> > LayoutTests/compositing/fixed-background-composited-html.html:27:
> > window.setTimeout(function() {
> > what's the setTimeout for?
> > 
> >
>
https://codereview.chromium.org/13462003/diff/57001/LayoutTests/compositing/f...
> > File LayoutTests/compositing/fixed-background-negative-z-index-fixed.html
> > (right):
> > 
> >
>
https://codereview.chromium.org/13462003/diff/57001/LayoutTests/compositing/f...
> > LayoutTests/compositing/fixed-background-negative-z-index-fixed.html:32:
> > window.setTimeout(function() {
> > what's the setTimeout for?
> 
> AFAICT, the setTimeouts serve no purpose, so I've removed them.

Friendly ping :)

[enne (OOO), 2013-07-03 18:26:57]

lgtm

https://codereview.chromium.org/17398002/diff/13001/Source/core/rendering/Ren...
File Source/core/rendering/RenderLayerCompositor.cpp (right):

https://codereview.chromium.org/17398002/diff/13001/Source/core/rendering/Ren...
Source/core/rendering/RenderLayerCompositor.cpp:1216: // similar between
platforms (unless we explicitly request dumping from the
layerTreeAsText is so fragile.  :(

[Ian Vollick, 2013-07-03 18:38:42]

+eseidel for WebSettings* OWNERS


On 2013/07/03 18:26:57, enne wrote:
> lgtm
> 
>
https://codereview.chromium.org/17398002/diff/13001/Source/core/rendering/Ren...
> File Source/core/rendering/RenderLayerCompositor.cpp (right):
> 
>
https://codereview.chromium.org/17398002/diff/13001/Source/core/rendering/Ren...
> Source/core/rendering/RenderLayerCompositor.cpp:1216: // similar between
> platforms (unless we explicitly request dumping from the
> layerTreeAsText is so fragile.  :(

Yeah, it totally is. It would be nice if we could return something that could be
easily interpreted by the js and would let us check certain things about the
layer tree rather that a braindead text comparison.

[eseidel, 2013-07-03 18:41:56]

I don't think I"m actually an OWNER for WebSettings, but lgtm.

[commit-bot: I haz the power, 2013-07-03 18:48:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/17398002/13001

[commit-bot: I haz the power, 2013-07-03 20:16:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/17398002/36001

[jamesr, 2013-07-03 20:55:27]

settings lgtm, but it looks like more work is required before landing the tests

https://codereview.chromium.org/17398002/diff/36001/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/17398002/diff/36001/LayoutTests/TestExpectati...
LayoutTests/TestExpectations:1437: crbug.com/180885
compositing/fixed-body-background-positioned.html [ Failure ]
we should rebaseline these to whatever results we produce and use the bug to
track the failure

https://codereview.chromium.org/17398002/diff/36001/LayoutTests/TestExpectati...
LayoutTests/TestExpectations:1440: # For reference tests, the expected and
actual appear to clipped differently.
shouldn't we figure this out before landing?

[Ian Vollick, 2013-07-03 22:11:31]

cq- based on jamesr's review.

On 2013/07/03 20:55:27, jamesr wrote:
> settings lgtm, but it looks like more work is required before landing the
tests
> 
>
https://codereview.chromium.org/17398002/diff/36001/LayoutTests/TestExpectations
> File LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/17398002/diff/36001/LayoutTests/TestExpectati...
> LayoutTests/TestExpectations:1437: crbug.com/180885
> compositing/fixed-body-background-positioned.html [ Failure ]
> we should rebaseline these to whatever results we produce and use the bug to
> track the failure
I thought that landing initially failing tests (a la TDD) and getting them
passing with the implementation of the feature, was the thing to do. Is that not
how things are usually done in blink?

> 
>
https://codereview.chromium.org/17398002/diff/36001/LayoutTests/TestExpectati...
> LayoutTests/TestExpectations:1440: # For reference tests, the expected and
> actual appear to clipped differently.
> shouldn't we figure this out before landing?
The reference test clipping issue appears unrelated to the feature (it happens
in ToT). I was hoping to land the failing test now because
 1. It exposes the clipping issue (and I would like to refer to it in the bug),
and
 2. It will also be a useful test of the bg-attachment fixed functionality once
the clipping issue is addressed.

It might make sense to create a dedicated test in another CL for 1 -- and I
would be happy to do that -- but I'm not sure why we'd hold up landing a test
exposing a bug until we've fixed said bug.

[Ian Vollick, 2013-07-04 17:47:56]

On 2013/07/03 22:11:31, vollick wrote:
> cq- based on jamesr's review.
> 
> On 2013/07/03 20:55:27, jamesr wrote:
> > settings lgtm, but it looks like more work is required before landing the
> tests
> > 
> >
>
https://codereview.chromium.org/17398002/diff/36001/LayoutTests/TestExpectations
> > File LayoutTests/TestExpectations (right):
> > 
> >
>
https://codereview.chromium.org/17398002/diff/36001/LayoutTests/TestExpectati...
> > LayoutTests/TestExpectations:1437: crbug.com/180885
> > compositing/fixed-body-background-positioned.html [ Failure ]
> > we should rebaseline these to whatever results we produce and use the bug to
> > track the failure
> I thought that landing initially failing tests (a la TDD) and getting them
> passing with the implementation of the feature, was the thing to do. Is that
not
> how things are usually done in blink?
My apologies, rbyers explained to me that having failing expectations lets us
ensure that we don't change the mode of failure. Submitted updated expectations.
> 
> > 
> >
>
https://codereview.chromium.org/17398002/diff/36001/LayoutTests/TestExpectati...
> > LayoutTests/TestExpectations:1440: # For reference tests, the expected and
> > actual appear to clipped differently.
> > shouldn't we figure this out before landing?
Conveniently, it looks like someone has fixed this bug! Given this fix and the
updated expectations above, I was able to ditch all changes to TestExpectations.

[jamesr, 2013-07-04 20:43:09]

Wonderful! lgtm

[commit-bot: I haz the power, 2013-07-04 20:59:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/17398002/42001

[commit-bot: I haz the power, 2013-07-04 20:59:54]

Can't process patch for file
LayoutTests/compositing/fixed-body-background-positioned-expected.png.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

[commit-bot: I haz the power, 2013-07-05 12:44:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/17398002/49001

[commit-bot: I haz the power, 2013-07-05 13:58:31]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-07-05 15:16:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/17398002/46002

[commit-bot: I haz the power, 2013-07-05 16:35:27]

Change committed as 153639