Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1739753004: [api] Don't store the serial number of templates in handles (Closed)

Created:
4 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Don't store the serial number of templates in handles We know it's a postive integer BUG= R=bmeurer@chromium.org Committed: https://crrev.com/49c1e71123ac1acf51ced8985450dac8c67b6b24 Cr-Commit-Position: refs/heads/master@{#34327}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/api-natives.cc View 1 6 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-26 12:52:54 UTC) #1
Benedikt Meurer
Nice. LGTM
4 years, 10 months ago (2016-02-26 12:53:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739753004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739753004/20001
4 years, 10 months ago (2016-02-26 12:56:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 13:21:25 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 13:22:06 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49c1e71123ac1acf51ced8985450dac8c67b6b24
Cr-Commit-Position: refs/heads/master@{#34327}

Powered by Google App Engine
This is Rietveld 408576698