Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1739713003: Ignore setting of navigation starting points for detached documents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3704 matching lines...) Expand 10 before | Expand all | Expand 10 after
3715 return !focusChangeBlocked; 3715 return !focusChangeBlocked;
3716 } 3716 }
3717 3717
3718 void Document::clearFocusedElement() 3718 void Document::clearFocusedElement()
3719 { 3719 {
3720 setFocusedElement(nullptr, FocusParams(SelectionBehaviorOnFocus::None, WebFo cusTypeNone, nullptr)); 3720 setFocusedElement(nullptr, FocusParams(SelectionBehaviorOnFocus::None, WebFo cusTypeNone, nullptr));
3721 } 3721 }
3722 3722
3723 void Document::setSequentialFocusNavigationStartingPoint(Node* node) 3723 void Document::setSequentialFocusNavigationStartingPoint(Node* node)
3724 { 3724 {
3725 if (!m_frame)
3726 return;
3725 if (!node) { 3727 if (!node) {
3726 m_sequentialFocusNavigationStartingPoint = nullptr; 3728 m_sequentialFocusNavigationStartingPoint = nullptr;
3727 return; 3729 return;
3728 } 3730 }
3729 ASSERT(node->document() == this); 3731 ASSERT(node->document() == this);
3730 if (!m_sequentialFocusNavigationStartingPoint) 3732 if (!m_sequentialFocusNavigationStartingPoint)
3731 m_sequentialFocusNavigationStartingPoint = Range::create(*this); 3733 m_sequentialFocusNavigationStartingPoint = Range::create(*this);
3732 m_sequentialFocusNavigationStartingPoint->selectNodeContents(node, ASSERT_NO _EXCEPTION); 3734 m_sequentialFocusNavigationStartingPoint->selectNodeContents(node, ASSERT_NO _EXCEPTION);
3733 } 3735 }
3734 3736
(...skipping 2263 matching lines...) Expand 10 before | Expand all | Expand 10 after
5998 #ifndef NDEBUG 6000 #ifndef NDEBUG
5999 using namespace blink; 6001 using namespace blink;
6000 void showLiveDocumentInstances() 6002 void showLiveDocumentInstances()
6001 { 6003 {
6002 Document::WeakDocumentSet& set = Document::liveDocumentSet(); 6004 Document::WeakDocumentSet& set = Document::liveDocumentSet();
6003 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6005 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6004 for (Document* document : set) 6006 for (Document* document : set)
6005 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 6007 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
6006 } 6008 }
6007 #endif 6009 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698