Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 17397011: Adding content_shell to the dependencies in the chromium_builder_tests target. (Closed)

Created:
7 years, 6 months ago by ananta
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adding content_shell to the dependencies in the chromium_builder_tests target. Some trybots bots, e.g. linux_clang, run webkit_tests, which use content_shell. The bot only builds chromium_builder_tests. Since content_shell wasn't part of this, webkit_tests didn't run an up-to-date content_shell binary on that bot, which led to problems e.g. in try run http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/117825/ on cl https://codereview.chromium.org/17420005/. Add content_shell to chromium_builder_tests to fix this. BUG=237249 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207486

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ananta
7 years, 6 months ago (2013-06-20 01:45:31 UTC) #1
Nico
Please make the CL description a bit longer: "Some trybots bots, e.g. linux_clang, run webkit_tests, ...
7 years, 6 months ago (2013-06-20 01:49:29 UTC) #2
ananta
On 2013/06/20 01:49:29, Nico wrote: > Please make the CL description a bit longer: > ...
7 years, 6 months ago (2013-06-20 01:55:06 UTC) #3
Nico
You didn't replace "<link>" with an actual link to the build where this went wrong ...
7 years, 6 months ago (2013-06-20 01:55:56 UTC) #4
ananta
On 2013/06/20 01:55:56, Nico wrote: > You didn't replace "<link>" with an actual link to ...
7 years, 6 months ago (2013-06-20 01:57:45 UTC) #5
Nico
On 2013/06/20 01:57:45, ananta wrote: > On 2013/06/20 01:55:56, Nico wrote: > > You didn't ...
7 years, 6 months ago (2013-06-20 01:59:17 UTC) #6
ananta
On 2013/06/20 01:59:17, Nico wrote: > On 2013/06/20 01:57:45, ananta wrote: > > On 2013/06/20 ...
7 years, 6 months ago (2013-06-20 02:00:35 UTC) #7
ananta
7 years, 6 months ago (2013-06-20 18:20:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r207486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698