Adding AvailabilityFinder to Doc Server

chrome/common/extensions/docs/server2/test_branch_utility.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from branch_utility import BranchUtility, ChannelInfo
+from test_data.canned_data import (CANNED_BRANCHES, CANNED_CHANNELS)
 
 class TestBranchUtility(object):
   '''Mimics BranchUtility to return valid-ish data without needing omahaproxy
   data.
   '''

[not at google - send to devlin, 2013/06/21 00:54:11]

almost what I meant. except, pass the branches and channels into a constructor
here, then whoever constructs the TestBranchUtility can pass in the canned data
if they wish. or, pass in their own data.

def __init__(self, branches, channels):
  self._branches = branches
  self._channels = channels

... etc

[epeterson, 2013/06/22 01:42:40]

Done. I also made a method similar to BranchUtility's Create method, so that
things creating TestBranchUtilities (like the servlets) don't necessarily need
to include canned_data.py.

   def GetAllChannelInfo(self):
     return [self.GetChannelInfo(channel)
             for channel in BranchUtility.GetAllChannelNames()]
 
   def GetChannelInfo(self, channel):
-    return ChannelInfo(channel,
-                       'fakebranch-%s' % channel,
-                       'fakeversion-%s' % channel)
+    version = CANNED_CHANNELS[channel]
+    return ChannelInfo(channel, self.GetBranchForVersion(version), version)
 
   def GetBranchForVersion(self, version):
-    return 'fakebranch-%s' % version
+    return CANNED_BRANCHES[version]
+
+  def GetChannelForVersion(self, version):
+    for channel in CANNED_CHANNELS.iterkeys():
+      if CANNED_CHANNELS[channel] == version:
+        return channel

[epeterson, 2013/06/21 00:48:26]

Can we reuse dicts from canned_data? This way we don't have a bunch of inlined
data within TestBranchUtility, and the servlet tests also don't need to worry
about passing in some kind of config.

[not at google - send to devlin, 2013/06/21 00:54:11]

answered above